Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932932AbbHKUuW (ORCPT ); Tue, 11 Aug 2015 16:50:22 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:51794 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932120AbbHKUuU (ORCPT ); Tue, 11 Aug 2015 16:50:20 -0400 Date: Tue, 11 Aug 2015 13:50:19 -0700 (PDT) Message-Id: <20150811.135019.576312282566025940.davem@davemloft.net> To: robert.richter@caviumnetworks.com Cc: ddaney@caviumnetworks.com, ddaney.cavm@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, tomasz.nowicki@linaro.org, sgoutham@cavium.com, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, mark.rutland@arm.com, rafael@kernel.org, david.daney@cavium.com Subject: Re: [PATCH v2 0/2] net: thunder: Add ACPI support. From: David Miller In-Reply-To: <20150811201237.GW4914@rric.localhost> References: <20150811.114908.1384923604512568161.davem@davemloft.net> <55CA5567.9010002@caviumnetworks.com> <20150811201237.GW4914@rric.localhost> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 11 Aug 2015 13:50:20 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1026 Lines: 25 From: Robert Richter Date: Tue, 11 Aug 2015 22:12:37 +0200 > On 11.08.15 13:04:55, David Daney wrote: >> >In the future it might be better structured to try and get the OF >> >node, and if that fails then try and use the ACPI method to obtain >> >these values. >> >> Our current approach, as you can see in the patch, is the opposite. If ACPI >> is being used, prefer that over the OF device tree. >> >> You seem to be recommending precedence for OF. It should be consistent >> across all drivers/sub-systems, so do you really think that OF before ACPI >> is the way to go? > > If ACPI is enabled then no OF function may be called at all. That makes no sense to me at all. If ACPI is enabled, the OF routines should return no nodes etc. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/