Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753564AbbHKVS4 (ORCPT ); Tue, 11 Aug 2015 17:18:56 -0400 Received: from mail-pd0-f180.google.com ([209.85.192.180]:33390 "EHLO mail-pd0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752149AbbHKVSz convert rfc822-to-8bit (ORCPT ); Tue, 11 Aug 2015 17:18:55 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Eric Anholt , linux-arm-kernel@lists.infradead.org From: Michael Turquette In-Reply-To: <1437420787-32137-2-git-send-email-eric@anholt.net> Cc: linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Stephen Warren" , "Lee Jones" , linux-clk@vger.kernel.org, "Stephen Boyd" , "Eric Anholt" References: <1437420787-32137-1-git-send-email-eric@anholt.net> <1437420787-32137-2-git-send-email-eric@anholt.net> Message-ID: <20150811211840.31346.28666@quantum> User-Agent: alot/0.3.5 Subject: Re: [PATCH v4 1/8] clk: bcm2835: Add binding docs for the Raspberry Pi clock provider Date: Tue, 11 Aug 2015 14:18:40 -0700 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3776 Lines: 101 Quoting Eric Anholt (2015-07-20 12:33:00) > The hardware clocks are not controllable by the ARM, so we have to > make requests to the firmware to do so from the VPU side. This will > let us replace fixed clocks in our DT with actual clock control (and > correct frequency information). > > Signed-off-by: Eric Anholt > Acked-by: Stephen Warren > Acked-by: Lee Jones Looks good to me. Do you want the clk patches to go through the clk tree or do you want them all together? For this patch feel free to add: Acked-by: Michael Turquette Regards, Mike > --- > > v2: Include the dt-bindings header in this commit instead of the next > one. Make the clock indices match the firmware clock IDs. Rename > the binding's compat string. Move the firmware phandle to be > under a vendor-specific namespace. > v4: Mention 'clk' in the subject instead of the more generic > dt/bindings. > > .../clock/raspberrypi,bcm2835-firmware-clocks.txt | 25 ++++++++++++++++++++++ > include/dt-bindings/clk/raspberrypi.h | 23 ++++++++++++++++++++ > 2 files changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/raspberrypi,bcm2835-firmware-clocks.txt > create mode 100644 include/dt-bindings/clk/raspberrypi.h > > diff --git a/Documentation/devicetree/bindings/clock/raspberrypi,bcm2835-firmware-clocks.txt b/Documentation/devicetree/bindings/clock/raspberrypi,bcm2835-firmware-clocks.txt > new file mode 100644 > index 0000000..0972602 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/raspberrypi,bcm2835-firmware-clocks.txt > @@ -0,0 +1,25 @@ > +Raspberry Pi firmware clock provider. > + > +The Raspberry Pi architecture doesn't provide direct access to the > +CLOCKMAN peripheral from the ARM side, so Linux has to make requests > +to the VPU firmware to program them. > + > +This binding uses the common clock binding: > +Documentation/devicetree/bindings/clock/clock-bindings.txt > + > +Required properties: > +- compatible: Should be "raspberrypi,bcm2835-firmware-clocks" > + > +- #clock-cells: Shall have value <1>. The permitted clock-specifier > + values can be found in > + include/dt-bindings/clk/raspberrypi.h. > + > +- raspberrypi,firmware: Phandle to the firmware driver node. > + > +Example: > + > +firmware_clocks: firmware-clocks { > + compatible = "raspberrypi,bcm2835-firmware-clocks"; > + #clock-cells = <1>; > + raspberrypi,firmware = <&firmware>; > +}; > diff --git a/include/dt-bindings/clk/raspberrypi.h b/include/dt-bindings/clk/raspberrypi.h > new file mode 100644 > index 0000000..ceec90f > --- /dev/null > +++ b/include/dt-bindings/clk/raspberrypi.h > @@ -0,0 +1,23 @@ > +#/* > + * Copyright �� 2015 Broadcom > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > +#ifndef _DT_BINDINGS_CLK_RASPBERRYPI_H > +#define _DT_BINDINGS_CLK_RASPBERRYPI_H > + > +#define RPI_CLOCK_EMMC 1 > +#define RPI_CLOCK_UART0 2 > +#define RPI_CLOCK_ARM 3 > +#define RPI_CLOCK_CORE 4 > +#define RPI_CLOCK_V3D 5 > +#define RPI_CLOCK_H264 6 > +#define RPI_CLOCK_ISP 7 > +#define RPI_CLOCK_SDRAM 8 > +#define RPI_CLOCK_PIXEL 9 > +#define RPI_CLOCK_PWM 10 > + > +#endif > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/