Date: Wed, 12 Aug 2015 08:09:27 +1000
From: NeilBrown <neil@brown.name>
To: Alexander Holler <holler@ahsoftware.de>
Cc: Felipe Balbi <balbi@ti.com>, Kishon Vijay Abraham I <kishon@ti.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 4.1 099/267] phy: twl4030-usb: remove incorrect
 pm_runtime_get_sync() in probe function.
Message-ID: <20150812080927.14113400@home.neil.brown.name>
In-Reply-To: <55CA6A59.1070008@ahsoftware.de>
References: <20150731194001.933895871@linuxfoundation.org>
	<20150731194005.016920253@linuxfoundation.org>
	<55C59952.1000503@ahsoftware.de>
	<55C5A657.7060003@ti.com>
	<20150809190017.39a056a8@home.neil.brown.name>
	<55C72F40.6010800@ahsoftware.de>
	<20150811182929.0c778016@home.neil.brown.name>
	<55CA6A59.1070008@ahsoftware.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1535
Lines: 39

On Tue, 11 Aug 2015 23:34:17 +0200 Alexander Holler
<holler@ahsoftware.de> wrote:

> Am 11.08.2015 um 10:29 schrieb NeilBrown:
> 
> > With the current mainline code (plus my twl4030 charger enhancements,
> > which are not deeply relevant), the refcount does go to zero when
> > nothing is plugged in, and goes to 2 when a regular USB cable is
> > plugged in.
> 
> Also I think it's just a little miswording (or extended typo), I'm not 
> using a regular USB cable, but an OTG cable when using the host mode of 
> the musb on the Beagleboard. Just to avoid confusion. Or do you talk 
> about the client mode when it goes to 2?

With an OTG cable, the usage_count would probably got to '1' because
the charger wouldn't be interested.

However the important point is that the usage_count goes to zero when
no cable is plugged in.

> 
> Besides that, I'm sorry to not be of further help. My deeper knowledge 
> about the musb sources in the kernel and u-boot (and the HW in 
> question), has gone lost and I've currently no real reason to refresh 
> that. ;)

Just reporting the problem is sometimes 90% for the bug fixed.
I'm confident I know what is happening.  What isn't clear is how best
to fix it without breaking something else... I suspect Felipe can help
with that.

Thanks,
NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/