Date: Tue, 11 Aug 2015 18:28:08 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Daniel Wagner <daniel.wagner@bmw-carit.de>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v0] tracing: Allow triggers to filter for CPU ids and
 process names
Message-ID: <20150811182808.75c9cf0f@gandalf.local.home>
In-Reply-To: <1439210146-24707-1-git-send-email-daniel.wagner@bmw-carit.de>
References: <1439210146-24707-1-git-send-email-daniel.wagner@bmw-carit.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1284
Lines: 37

On Mon, 10 Aug 2015 14:35:46 +0200
Daniel Wagner <daniel.wagner@bmw-carit.de> wrote:

> By extending the filter rules by more generic fields
> we can write triggers filters like
> 
>   echo 'stacktrace if cpu == 1' > \
> 	/sys/kernel/debug/tracing/events/raw_syscalls/sys_enter/trigger
> 
> or
> 
>   echo 'stacktrace if comm == sshd'  > \
> 	/sys/kernel/debug/tracing/events/raw_syscalls/sys_enter/trigger
> 
> CPU and COMM are not part of struct trace_entry. We could add the two
> new fields to ftrace_common_field list and fix up all depending
> sides. But that looks pretty ugly. Another thing I would like to
> avoid that the 'format' file contents changes.
> 
> All this can be avoided by introducing another list which contains
> non field members of struct trace_entry.
> 
> Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: linux-kernel@vger.kernel.org

v0? Expect more revisions? ;-)

Looks fine. I pulled it into my queue.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/