Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933091AbbHLAGg (ORCPT ); Tue, 11 Aug 2015 20:06:36 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:15616 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932265AbbHLAGe (ORCPT ); Tue, 11 Aug 2015 20:06:34 -0400 X-AuditID: cbfec7f5-f794b6d000001495-4e-55ca8e069e2f Message-id: <55CA8E05.1000704@samsung.com> Date: Wed, 12 Aug 2015 09:06:29 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-version: 1.0 To: Joonyoung Shim , rtc-linux@googlegroups.com Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, cw00.choi@samsung.com Subject: Re: [PATCH 1/4] rtc: s3c: add missing clk control References: <1439292502-22912-1-git-send-email-jy0922.shim@samsung.com> In-reply-to: <1439292502-22912-1-git-send-email-jy0922.shim@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHLMWRmVeSWpSXmKPExsVy+t/xa7psfadCDTa+V7ZYcvEqu0XHtcVM Fte/PGe1eHHvIovF6xeGFpd3zWGzmHF+H5PF/s4ORgcOjyebLjJ67Jl4ks2jb8sqRo/p834y eXzeJBfAGsVlk5Kak1mWWqRvl8CVsWVSH2PBEeaK3umhDYw/mLoYOTkkBEwkjl2/zwxhi0lc uLeerYuRi0NIYCmjxK1DzxghnC+MEnPXPAOr4hXQkvh+7AkbiM0ioCqxc8ZfVhCbTcBYYvPy JWBxUYEIieWrTzJC1AtK/Jh8jwXEFhHwkPi56Q3YBmaBWYwSU589BTtDWMBK4tKhHWC2kIC7 xL9l28GaOYEabk26DNTMAdSgJ3H/ohZImFlAXmLzmrfMExiBhiCsmIVQNQtJ1QJG5lWMoqml yQXFSem5RnrFibnFpXnpesn5uZsYIaH+dQfj0mNWhxgFOBiVeHgzvE+GCrEmlhVX5h5ilOBg VhLhvWF1KlSINyWxsiq1KD++qDQntfgQozQHi5I478xd70OEBNITS1KzU1MLUotgskwcnFIN jPlBevF79G7Ku3hdqfhgaXN3tR5b/36TqdJP5zywCJ8XwxK63+lDUlF++RT1uF1ZVfcqQiNZ fF7eNrvl7xqUusLjYHbDmqmXF/Nx3v5mkDez9trWuxNNUl+LX/1o/PulIteT9ctiFm82n/E7 /17lp2dbdtd1/CxU2+6Q92CvhbTg/imBB18eXKzEUpyRaKjFXFScCAB93Ss+cQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 682 Lines: 20 On 11.08.2015 20:28, Joonyoung Shim wrote: > It's missed to call clk_unprepare() about info->rtc_src_clk in > s3c_rtc_remove and to call clk_disable_unprepare about info->rtc_clk in > error routine of s3c_rtc_probe. > > Signed-off-by: Joonyoung Shim > --- > drivers/rtc/rtc-s3c.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/