Date: Tue, 11 Aug 2015 19:29:10 -0500
From: Felipe Balbi <balbi@ti.com>
To: NeilBrown <neil@brown.name>
CC: Alexander Holler <holler@ahsoftware.de>, Felipe Balbi <balbi@ti.com>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH 4.1 099/267] phy: twl4030-usb: remove incorrect
 pm_runtime_get_sync() in probe function.
Message-ID: <20150812002910.GB5287@saruman.tx.rr.com>
Reply-To: <balbi@ti.com>
References: <20150731194001.933895871@linuxfoundation.org>
 <20150731194005.016920253@linuxfoundation.org>
 <55C59952.1000503@ahsoftware.de>
 <55C5A657.7060003@ti.com>
 <20150809190017.39a056a8@home.neil.brown.name>
 <55C72F40.6010800@ahsoftware.de>
 <20150811182929.0c778016@home.neil.brown.name>
 <55CA6A59.1070008@ahsoftware.de>
 <20150812080927.14113400@home.neil.brown.name>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="pvezYHf7grwyp3Bc"
Content-Disposition: inline
In-Reply-To: <20150812080927.14113400@home.neil.brown.name>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 3100
Lines: 85

--pvezYHf7grwyp3Bc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, Aug 12, 2015 at 08:09:27AM +1000, NeilBrown wrote:
> On Tue, 11 Aug 2015 23:34:17 +0200 Alexander Holler
> <holler@ahsoftware.de> wrote:
>=20
> > Am 11.08.2015 um 10:29 schrieb NeilBrown:
> >=20
> > > With the current mainline code (plus my twl4030 charger enhancements,
> > > which are not deeply relevant), the refcount does go to zero when
> > > nothing is plugged in, and goes to 2 when a regular USB cable is
> > > plugged in.
> >=20
> > Also I think it's just a little miswording (or extended typo), I'm not=
=20
> > using a regular USB cable, but an OTG cable when using the host mode of=
=20
> > the musb on the Beagleboard. Just to avoid confusion. Or do you talk=20
> > about the client mode when it goes to 2?
>=20
> With an OTG cable, the usage_count would probably got to '1' because
> the charger wouldn't be interested.
>=20
> However the important point is that the usage_count goes to zero when
> no cable is plugged in.
>=20
> >=20
> > Besides that, I'm sorry to not be of further help. My deeper knowledge=
=20
> > about the musb sources in the kernel and u-boot (and the HW in=20
> > question), has gone lost and I've currently no real reason to refresh=
=20
> > that. ;)
>=20
> Just reporting the problem is sometimes 90% for the bug fixed.
> I'm confident I know what is happening.  What isn't clear is how best
> to fix it without breaking something else... I suspect Felipe can help
> with that.

It'll take me a while to be able to look at this. I don't have any
platform with TWL4030 (IIRC, AM335x uses tps65218 instead). Besides, I
have a slightly bigger problem to look at (MUSB + some hubs + CP2108
fails sometimes).

If I get some time, I'll try to have a look, but it might take a few
weeks.

cheers

--=20
balbi

--pvezYHf7grwyp3Bc
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJVypNWAAoJEIaOsuA1yqREQ14QALE0A6Fzl51c3YuxWgQ8sveN
GGxlRiDglMtHlY+6Y+O16iiuy5PvN/CwBd0ykq6Q6LrV1/a9WpQTrcjXw3Rg2hoO
HVnse/acjhKbZ2fpjVRMJi/ccyCXLl7zfrpwp/xzMbBnZvlokHbFcKW3dmaV3tDG
3CqCANX8njg259yTNsX8CD0IxK9Q1RzffZ2tye6KKajhvYHRLGOE5WL8N9XaFY6i
V0TNPC+k5IRoLgaBZuCYBHS7fyYaNKDiZNscJipK3g8B64TJoGu2RQ8P7OZSlAHh
GNu8uxMsCyzGobdZTtr7YNJ8GhFhi+PMMpXi1F+TV+1xoB00zI7xzoIyPlLCLEhi
3jxySnhrL+qLGu9KRdPkqsQ/Y4deCd8FOurvye2wtsOBT6/mwhvyH5xxa2/270Yx
6ntM+bS0fk8hp1VSoHhsi+2qPvIVBKUU8eqHoVlD9YE5X7m53fLa7iPFet1m8pfr
wZsoYk3yJobv1xe9M31d7mZLQSjOl9qbCRN7r8tNAzsJwaHgUzpq+2N3HGIj5qt0
VPBTHr8Ea45mV9/RarACqLQDh3D6Ne4YqCVlXTujAUYv/q5oNrFljKdG0IYunMEF
YPIlbYtzFRRUgbuDZ2USnyrB/L+xFl5bFRxsYnMZj5tTIP0O3Bg+EtiOGToV43/A
HowE5X7hyt/v60piVNFa
=ELGM
-----END PGP SIGNATURE-----

--pvezYHf7grwyp3Bc--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/