Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933317AbbHLAae (ORCPT ); Tue, 11 Aug 2015 20:30:34 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:36296 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932798AbbHLAac (ORCPT ); Tue, 11 Aug 2015 20:30:32 -0400 To: Christoph Hellwig Cc: Jens Axboe , linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, dm-devel@redhat.com, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] block: cleanup blkdev_ioctl From: "Martin K. Petersen" Organization: Oracle Corporation References: <1438672271-11309-1-git-send-email-hch@lst.de> <1438672271-11309-2-git-send-email-hch@lst.de> Date: Tue, 11 Aug 2015 20:29:55 -0400 In-Reply-To: <1438672271-11309-2-git-send-email-hch@lst.de> (Christoph Hellwig's message of "Tue, 4 Aug 2015 09:11:06 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 665 Lines: 18 >>>>> "Christoph" == Christoph Hellwig writes: Christoph> Split out helpers for all non-trivial ioctls to make this Christoph> function simpler, and also start passing around a pointer Christoph> version of the argument, as that's what most ioctl handlers Christoph> actually need. Looks good. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/