Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933524AbbHLCIn (ORCPT ); Tue, 11 Aug 2015 22:08:43 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:21372 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933386AbbHLCIm (ORCPT ); Tue, 11 Aug 2015 22:08:42 -0400 Subject: Re: [PATCH] x86/mce: fix failed to reenable cmci when swiching to interrupt mode To: "Luck, Tony" , Borislav Petkov References: <1439287777-8270-1-git-send-email-xiexiuqi@huawei.com> <20150811144637.GA5573@nazgul.tnic> <3908561D78D1C84285E8C5FCA982C28F32ADCEE3@ORSMSX114.amr.corp.intel.com> CC: "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "x86@kernel.org" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "zhangliguang@huawei.com" From: Xie XiuQi Message-ID: <55CAAA9F.70303@huawei.com> Date: Wed, 12 Aug 2015 10:08:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:42.0) Gecko/20100101 Thunderbird/42.0a1 MIME-Version: 1.0 In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F32ADCEE3@ORSMSX114.amr.corp.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.19.210] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 775 Lines: 24 On 2015/8/12 2:52, Luck, Tony wrote: >> Well, ok, but do it differently, please: rename >> cmci_storm_disable_banks() to cmci_storm_switch_banks(bool on) which >> turns them on and off. Unless Tony has a better suggestion... > > I like the boolean argument ... but not the "switch_banks" name. It sounds more > like we are juggling between banks, rather than setting a switch/flag in a bank. > > How does "cmci_storm_set_cmci(bool on)" sound? Too many "cmci" in one name? Thanks, I'll use this name. -- Xie XiuQi > > -Tony > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/