Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933485AbbHLCa3 (ORCPT ); Tue, 11 Aug 2015 22:30:29 -0400 Received: from blu004-omc1s31.hotmail.com ([65.55.116.42]:54036 "EHLO BLU004-OMC1S31.hotmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933064AbbHLCa2 (ORCPT ); Tue, 11 Aug 2015 22:30:28 -0400 X-TMN: [zf9OU1AZekSiYM1a5FDnciYdUOZd6GDf] X-Originating-Email: [wanpeng.li@hotmail.com] Message-ID: Subject: Re: [PATCH v2 3/5] mm/hwpoison: introduce put_hwpoison_page to put refcount for memory error handling To: Andrew Morton References: <1439206103-86829-1-git-send-email-wanpeng.li@hotmail.com> <20150811162449.77212ec2a80258f5aff8a224@linux-foundation.org> CC: Naoya Horiguchi , linux-mm@kvack.org, linux-kernel@vger.kernel.org From: Wanpeng Li Date: Wed, 12 Aug 2015 10:30:21 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <20150811162449.77212ec2a80258f5aff8a224@linux-foundation.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 12 Aug 2015 02:30:26.0668 (UTC) FILETIME=[D927FAC0:01D0D4A6] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1264 Lines: 49 On 8/12/15 7:24 AM, Andrew Morton wrote: > On Mon, 10 Aug 2015 19:28:21 +0800 Wanpeng Li wrote: > >> Introduce put_hwpoison_page to put refcount for memory >> error handling. >> >> ... >> >> --- a/mm/memory-failure.c >> +++ b/mm/memory-failure.c >> @@ -922,6 +922,27 @@ int get_hwpoison_page(struct page *page) >> } >> EXPORT_SYMBOL_GPL(get_hwpoison_page); >> >> +/** >> + * put_hwpoison_page() - Put refcount for memory error handling: >> + * @page: raw error page (hit by memory error) >> + */ >> +void put_hwpoison_page(struct page *page) >> +{ >> + struct page *head = compound_head(page); >> + >> + if (PageHuge(head)) { >> + put_page(head); >> + return; >> + } >> + >> + if (PageTransHuge(head)) >> + if (page != head) >> + put_page(head); >> + >> + put_page(page); >> +} >> +EXPORT_SYMBOL_GPL(put_hwpoison_page); > I don't believe the export is needed? ERROR: "put_hwpoison_page" [mm/hwpoison-inject.ko] undefined! So I'm afraid it should be needed. Regards, Wanpeng Li -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/