From: Wang Dongsheng <Dongsheng.Wang@freescale.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
CC: "shawn.guo@linaro.org" <shawn.guo@linaro.org>,
        Huan Wang <alison.wang@freescale.com>,
        "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "sandeep_n@ti.com" <sandeep_n@ti.com>,
        "hdegoede@redhat.com" <hdegoede@redhat.com>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v2 1/2] soc/fsl: add freescale dir for SOC specific
 drivers
Thread-Topic: [PATCH v2 1/2] soc/fsl: add freescale dir for SOC specific
 drivers
Thread-Index: AQHQ1MP2jfX7R1agm0Om+LeFW0Tl4J4H+/SAgAAB3qCAAAOCAIAAAW6w
Date: Wed, 12 Aug 2015 08:10:12 +0000
Message-ID: <SN1PR0301MB16166F525E73A892C673F2C19D7E0@SN1PR0301MB1616.namprd03.prod.outlook.com>
References: <1439358807-9024-1-git-send-email-dongsheng.wang@freescale.com>
 <20150812074439.GF7557@n2100.arm.linux.org.uk>
 <SN1PR0301MB1616C942574FB3261B811DB19D7E0@SN1PR0301MB1616.namprd03.prod.outlook.com>
 <20150812080354.GH7557@n2100.arm.linux.org.uk>
In-Reply-To: <20150812080354.GH7557@n2100.arm.linux.org.uk>
Accept-Language: zh-CN, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2015 08:10:12.0786
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB0874
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3428
Lines: 103


> -----Original Message-----
> From: Russell King - ARM Linux [mailto:linux@arm.linux.org.uk]
> Sent: Wednesday, August 12, 2015 4:04 PM
> To: Wang Dongsheng-B40534
> Cc: shawn.guo@linaro.org; Wang Huan-B18965; linus.walleij@linaro.org; linux-
> kernel@vger.kernel.org; sandeep_n@ti.com; hdegoede@redhat.com; linux-arm-
> kernel@lists.infradead.org
> Subject: Re: [PATCH v2 1/2] soc/fsl: add freescale dir for SOC specific drivers
> 
> On Wed, Aug 12, 2015 at 08:01:32AM +0000, Wang Dongsheng wrote:
> > Hi Russell,
> >
> > Thanks for your review. :)
> >
> > > -----Original Message-----
> > > From: Russell King - ARM Linux [mailto:linux@arm.linux.org.uk]
> > > Sent: Wednesday, August 12, 2015 3:45 PM
> > > To: Wang Dongsheng-B40534
> > > Cc: shawn.guo@linaro.org; Wang Huan-B18965;
> > > linus.walleij@linaro.org; linux- kernel@vger.kernel.org;
> > > sandeep_n@ti.com; hdegoede@redhat.com; linux-arm-
> > > kernel@lists.infradead.org
> > > Subject: Re: [PATCH v2 1/2] soc/fsl: add freescale dir for SOC
> > > specific drivers
> > >
> > > On Wed, Aug 12, 2015 at 01:53:26PM +0800, Dongsheng Wang wrote:
> > > > diff --git a/drivers/soc/fsl/Kconfig b/drivers/soc/fsl/Kconfig new
> > > > file mode 100644 index 0000000..863d1ef
> > > > --- /dev/null
> > > > +++ b/drivers/soc/fsl/Kconfig
> > > > @@ -0,0 +1,18 @@
> > > > +#
> > > > +# Freescale SOC drivers
> > > > +#
> > > > +menuconfig FSL_SOC_DRIVERS
> > > > +	bool "Freescale Soc Drivers"
> > > > +	default n
> > >
> > > No need for default n.
> >
> > Thanks. Fix it in next version.
> >
> > > > +	help
> > > > +	Say y here to enable Freescale LS1021A Soc Device Drivers support.
> > > > +	The Soc Drivers provides the device driver that is a specific block
> > > > +	or feature on LS1021A platform.
> > >
> > > Help text should be indented by two spaces as per almost every other help
> text.
> > >
> >
> > Thanks. My mistake...
> >
> > > > +
> > > > +if LS1_SOC_DRIVERS
> > > > +	source "drivers/soc/fsl/ls1/Kconfig"
> > > > +endif
> > > > diff --git a/drivers/soc/fsl/Makefile b/drivers/soc/fsl/Makefile
> > > > new file mode 100644 index 0000000..b4215dd
> > > > --- /dev/null
> > > > +++ b/drivers/soc/fsl/Makefile
> > > > @@ -0,0 +1,6 @@
> > > > +#
> > > > +# Makefile for Freescale Soc specific device drivers.
> > > > +#
> > > > +
> > > > +obj-$(CONFIG_LS1_SOC_DRIVERS) += ls1/
> > > > +
> > > > diff --git a/drivers/soc/fsl/ls1/Kconfig
> > > > b/drivers/soc/fsl/ls1/Kconfig new file mode 100644 index
> > > > 0000000..7556f44
> > > > --- /dev/null
> > > > +++ b/drivers/soc/fsl/ls1/Kconfig
> > > > @@ -0,0 +1,3 @@
> > > > +#
> > > > +# LS-1 Soc drivers
> > > > +#
> > >
> > > Doesn't this directory need a Makefile as well?
> > >
> >
> > 2/2 patch add a config option and Makefile for this.
> 
> If _just_ this patch is merged, it creates a build problem as
> CONFIG_LS1_SOC_DRIVERS can be enabled, which will cause the kbuild to decend
> into drivers/soc/fsl/ls1, where it will stop due to the missing build error.
> 
> Please fix this by adding at least an empty Makefile to this directory.
> Do not rely on patch 2 being merged to "fix" this.
> 

Um..Yes, miss it. Fix it in next version. :)

Regards,
-Dongsheng

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/