Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755936AbbHLJqI (ORCPT ); Wed, 12 Aug 2015 05:46:08 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:35696 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751692AbbHLJqC (ORCPT ); Wed, 12 Aug 2015 05:46:02 -0400 Date: Wed, 12 Aug 2015 11:45:58 +0200 From: Michal Hocko To: Eric B Munson Cc: Andrew Morton , Vlastimil Babka , Heiko Carstens , Geert Uytterhoeven , Catalin Marinas , Stephen Rothwell , Guenter Roeck , Andrea Arcangeli , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, adi-buildroot-devel@lists.sourceforge.net, linux-cris-kernel@axis.com, linux-ia64@vger.kernel.org, linux-m68k@vger.kernel.org, linux-am33-list@redhat.com, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v7 2/6] mm: mlock: Add new mlock system call Message-ID: <20150812094558.GD14940@dhcp22.suse.cz> References: <1439097776-27695-1-git-send-email-emunson@akamai.com> <1439097776-27695-3-git-send-email-emunson@akamai.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439097776-27695-3-git-send-email-emunson@akamai.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4864 Lines: 137 On Sun 09-08-15 01:22:52, Eric B Munson wrote: > With the refactored mlock code, introduce a new system call for mlock. > The new call will allow the user to specify what lock states are being > added. mlock2 is trivial at the moment, but a follow on patch will add > a new mlock state making it useful. Looks good to me Acked-by: Michal Hocko > Signed-off-by: Eric B Munson > Acked-by: Vlastimil Babka > Cc: Michal Hocko > Cc: Vlastimil Babka > Cc: Heiko Carstens > Cc: Geert Uytterhoeven > Cc: Catalin Marinas > Cc: Stephen Rothwell > Cc: Guenter Roeck > Cc: Andrea Arcangeli > Cc: linux-alpha@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: adi-buildroot-devel@lists.sourceforge.net > Cc: linux-cris-kernel@axis.com > Cc: linux-ia64@vger.kernel.org > Cc: linux-m68k@lists.linux-m68k.org > Cc: linux-am33-list@redhat.com > Cc: linux-parisc@vger.kernel.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-s390@vger.kernel.org > Cc: linux-sh@vger.kernel.org > Cc: sparclinux@vger.kernel.org > Cc: linux-xtensa@linux-xtensa.org > Cc: linux-api@vger.kernel.org > Cc: linux-arch@vger.kernel.org > Cc: linux-mm@kvack.org > --- > arch/x86/entry/syscalls/syscall_32.tbl | 1 + > arch/x86/entry/syscalls/syscall_64.tbl | 1 + > include/linux/syscalls.h | 2 ++ > include/uapi/asm-generic/unistd.h | 4 +++- > kernel/sys_ni.c | 1 + > mm/mlock.c | 8 ++++++++ > 6 files changed, 16 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/entry/syscalls/syscall_32.tbl b/arch/x86/entry/syscalls/syscall_32.tbl > index ef8187f..8e06da6 100644 > --- a/arch/x86/entry/syscalls/syscall_32.tbl > +++ b/arch/x86/entry/syscalls/syscall_32.tbl > @@ -365,3 +365,4 @@ > 356 i386 memfd_create sys_memfd_create > 357 i386 bpf sys_bpf > 358 i386 execveat sys_execveat stub32_execveat > +360 i386 mlock2 sys_mlock2 > diff --git a/arch/x86/entry/syscalls/syscall_64.tbl b/arch/x86/entry/syscalls/syscall_64.tbl > index 9ef32d5..67601e7 100644 > --- a/arch/x86/entry/syscalls/syscall_64.tbl > +++ b/arch/x86/entry/syscalls/syscall_64.tbl > @@ -329,6 +329,7 @@ > 320 common kexec_file_load sys_kexec_file_load > 321 common bpf sys_bpf > 322 64 execveat stub_execveat > +324 common mlock2 sys_mlock2 > > # > # x32-specific system call numbers start at 512 to avoid cache impact > diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h > index b45c45b..56a3d59 100644 > --- a/include/linux/syscalls.h > +++ b/include/linux/syscalls.h > @@ -884,4 +884,6 @@ asmlinkage long sys_execveat(int dfd, const char __user *filename, > const char __user *const __user *argv, > const char __user *const __user *envp, int flags); > > +asmlinkage long sys_mlock2(unsigned long start, size_t len, int flags); > + > #endif > diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h > index e016bd9..14a6013 100644 > --- a/include/uapi/asm-generic/unistd.h > +++ b/include/uapi/asm-generic/unistd.h > @@ -709,9 +709,11 @@ __SYSCALL(__NR_memfd_create, sys_memfd_create) > __SYSCALL(__NR_bpf, sys_bpf) > #define __NR_execveat 281 > __SC_COMP(__NR_execveat, sys_execveat, compat_sys_execveat) > +#define __NR_mlock2 282 > +__SYSCALL(__NR_mlock2, sys_mlock2) > > #undef __NR_syscalls > -#define __NR_syscalls 282 > +#define __NR_syscalls 283 > > /* > * All syscalls below here should go away really, > diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c > index 7995ef5..4818b71 100644 > --- a/kernel/sys_ni.c > +++ b/kernel/sys_ni.c > @@ -193,6 +193,7 @@ cond_syscall(sys_mlock); > cond_syscall(sys_munlock); > cond_syscall(sys_mlockall); > cond_syscall(sys_munlockall); > +cond_syscall(sys_mlock2); > cond_syscall(sys_mincore); > cond_syscall(sys_madvise); > cond_syscall(sys_mremap); > diff --git a/mm/mlock.c b/mm/mlock.c > index 5692ee5..3094f27 100644 > --- a/mm/mlock.c > +++ b/mm/mlock.c > @@ -643,6 +643,14 @@ SYSCALL_DEFINE2(mlock, unsigned long, start, size_t, len) > return do_mlock(start, len, VM_LOCKED); > } > > +SYSCALL_DEFINE3(mlock2, unsigned long, start, size_t, len, int, flags) > +{ > + if (flags) > + return -EINVAL; > + > + return do_mlock(start, len, VM_LOCKED); > +} > + > SYSCALL_DEFINE2(munlock, unsigned long, start, size_t, len) > { > int ret; > -- > 1.9.1 -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/