Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965046AbbHLK0z (ORCPT ); Wed, 12 Aug 2015 06:26:55 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:38653 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752130AbbHLK0w (ORCPT ); Wed, 12 Aug 2015 06:26:52 -0400 X-AuditID: cbfee68d-f79106d00000728c-84-55cb1f6b8a94 Message-id: <55CB1F6C.4080207@samsung.com> Date: Wed, 12 Aug 2015 19:26:52 +0900 From: Joonyoung Shim User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Krzysztof Kozlowski , rtc-linux@googlegroups.com Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, cw00.choi@samsung.com Subject: Re: [PATCH 3/4] rtc: s3c: use unified functions for enable/disable of clk References: <1439292502-22912-1-git-send-email-jy0922.shim@samsung.com> <1439292502-22912-3-git-send-email-jy0922.shim@samsung.com> <55CA8EDE.8000006@samsung.com> In-reply-to: <55CA8EDE.8000006@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrAIsWRmVeSWpSXmKPExsWyRsSkUDdb/nSowYPrkhZLLl5lt+i4tpjJ 4vqX56wWr18YWlzeNYfNYsb5fUwW+zs7GB3YPZ5susjosWfiSTaPvi2rGD2mz/vJ5PF5k1wA axSXTUpqTmZZapG+XQJXxo5Pd1gLFrFXXN1xgKmB8StrFyMnh4SAicSMEzdZIGwxiQv31rN1 MXJxCAmsYJS40dMM5HCAFXUdVYGIL2WUeNiynxXCecAo0Xj4AxNIN6+AlsTGB+fYQWwWAVWJ l5OuMYPYbAJ6Ene2HQerERUIkzgzo4MFol5Q4sfke2C2iICvxIOVR1lAhjILzGKUmPrsKViD sECIxL9tR6FOWsYo0fnjNzPISZwC2hJH/hmCmMxAC+5f1AIpZxaQl9i85i0zxDfX2CXmz82H uEdA4tvkQywQz8hKbDoAVSIpcXDFDZYJjGKzkFw0C2HoLCRDFzAyr2IUTS1ILihOSi8y1CtO zC0uzUvXS87P3cQIjLjT/5717mC8fcD6EKMAB6MSD6/BxFOhQqyJZcWVuYcYTYGOmMgsJZqc D4zrvJJ4Q2MzIwtTE1NjI3NLMyVxXkWpn8FCAumJJanZqakFqUXxRaU5qcWHGJk4OKUaGB30 S5//2S11omd928aZ619z/su78H6TvlCc/vs/bLb7dDUlf7jNeMF5Pbf1T7pZYOwdRnHJxEed c48dVHmSJ9+VHnHYySqOw1m+erLmsXnnS0y5dyzSPjz/+QfFhfYmetwmB6SKLpQZ1jVe41e7 p/Yo/lv1hUKbkEnLZHZUfyyp/see8TiCWYmlOCPRUIu5qDgRAJTqJhazAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsVy+t9jAd1s+dOhBt9ei1gsuXiV3aLj2mIm i+tfnrNavH5haHF51xw2ixnn9zFZ7O/sYHRg93iy6SKjx56JJ9k8+rasYvSYPu8nk8fnTXIB rFENjDYZqYkpqUUKqXnJ+SmZeem2St7B8c7xpmYGhrqGlhbmSgp5ibmptkouPgG6bpk5QGco KZQl5pQChQISi4uV9O0wTQgNcdO1gGmM0PUNCYLrMTJAAwlrGDN2fLrDWrCIveLqjgNMDYxf WbsYOTgkBEwkuo6qdDFyApliEhfurWfrYuTiEBJYyijxsGU/K4TzgFGi8fAHJpAqXgEtiY0P zrGD2CwCqhIvJ11jBrHZBPQk7mw7DlYjKhAmcWZGBwtEvaDEj8n3wGwRAV+JByuPsoAMZRaY xSgx9dlTsAZhgRCJf9uOQq1exijR+eM3M8h5nALaEkf+GYKYzEAL7l/UAilnFpCX2LzmLfME RqAhCCtmIVTNQlK1gJF5FaNEakFyQXFSeq5hXmq5XnFibnFpXrpecn7uJkZwXD+T2sF4cJf7 IUYBDkYlHl6DiadChVgTy4orcw8xSnAwK4nw9twHCvGmJFZWpRblxxeV5qQWH2I0BYbBRGYp 0eR8YMrJK4k3NDYxM7I0Mje0MDI2VxLnld2wOVRIID2xJDU7NbUgtQimj4mDU6qBcYKkWsbZ WYldHsK625SXJpQlvT8j2l21wbptS2a1tpVCNivXT6clug7X/q/gMNrymvPMx4iJHyOW31NY KvRs1ba/93kmZs18deDzqZe17ud4XrvIiU5c1v17sdj2wAfMZ+64n1u0a8fDZ01XT/prv3ZL OtFXvzOprnz3rXvvHrG9aHZbZsP5P0KJpTgj0VCLuag4EQDXuQd4AQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1151 Lines: 29 On 08/12/2015 09:10 AM, Krzysztof Kozlowski wrote: > On 11.08.2015 20:28, Joonyoung Shim wrote: >> The driver uses clk_prepare_enable()/clk_disable_unprepare() only in >> probe only, elsewhere, use the unified functions for enable/disable of >> clk, e.g. s3c_rtc_enable_clk() / s3c_rtc_disable_clk(), so it's better >> to use them for consistency of code. >> >> Signed-off-by: Joonyoung Shim >> --- >> drivers/rtc/rtc-s3c.c | 14 +++++++++----- >> 1 file changed, 9 insertions(+), 5 deletions(-) > > First of all - the code is larger (9 insertions, 5 deletion) so I have > doubts if this is better. > > Second - this is not equivalent change. The s3c_rtc_enable_clk/disable > calls grab spin lock which is not necessary in probe. > I made this patch because of patch 4/4, but patch 4/4 should be removed dependency from previous patches, so i will drop this patch. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/