Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934311AbbHLKan (ORCPT ); Wed, 12 Aug 2015 06:30:43 -0400 Received: from tundra.namei.org ([65.99.196.166]:33617 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754570AbbHLKah (ORCPT ); Wed, 12 Aug 2015 06:30:37 -0400 Date: Wed, 12 Aug 2015 20:30:10 +1000 (AEST) From: James Morris To: David Woodhouse cc: David Howells , mcgrof@gmail.com, Mimi Zohar , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [GIT PULL] MODSIGN: Use PKCS#7 for module signatures [ver #7a] In-Reply-To: <1439375000.3100.70.camel@infradead.org> Message-ID: References: <15181.1439323425@warthog.procyon.org.uk> <1439363265.3100.30.camel@infradead.org> <1439370753.3100.58.camel@infradead.org> <1439373041.3100.64.camel@infradead.org> <1439375000.3100.70.camel@infradead.org> User-Agent: Alpine 2.20 (LRH 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1144 Lines: 39 On Wed, 12 Aug 2015, David Woodhouse wrote: > On Wed, 2015-08-12 at 20:08 +1000, James Morris wrote: > > make-3.81-20.el6.x86_64 > > > > The machine is not accessible, sorry. > > No matter. I have a CentOS 6 VM in which I can attempt to reproduce. > > > Where is MODULE_SIG_KEY_FILENAME assigned? > > At about line 243: > > $(eval $(call config_filename,MODULE_SIG_KEY)) > > Or, more to the point, somewhere in here... you may now understand why > I made a new jug of coffee. I had torture-tested this with fairly much > every pathology I could think of. And you've managed to break it with > the *default* case. Congratulations. You just made me cry. You made me read Make documentation -- I think we're even. > # > define config_filename = This may be relevant: http://stackoverflow.com/questions/13260396/gnu-make-3-81-eval-function-not-working -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/