Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754942AbbHLKoG (ORCPT ); Wed, 12 Aug 2015 06:44:06 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:40192 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751403AbbHLKoB (ORCPT ); Wed, 12 Aug 2015 06:44:01 -0400 Date: Wed, 12 Aug 2015 11:43:55 +0100 From: Mark Brown To: Markus Pargmann Cc: Jonathan Cameron , Srinivas Pandruvada , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Message-ID: <20150812104355.GS10748@sirena.org.uk> References: <1439374365-20623-1-git-send-email-mpa@pengutronix.de> <1439374365-20623-5-git-send-email-mpa@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="O3bhLwMadv7h6/J9" Content-Disposition: inline In-Reply-To: <1439374365-20623-5-git-send-email-mpa@pengutronix.de> X-Cookie: if it GLISTENS, gobble it!! User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 04/20] regmap: Do not skip format initialization X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1564 Lines: 41 --O3bhLwMadv7h6/J9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 12, 2015 at 12:12:29PM +0200, Markus Pargmann wrote: > It is not obvious why format initialization is skipped here. format > functions are used for example in regmap_bulk_read even if bus is not > set. So they are used even if skipped here which leads to null pointer > errors. > This patch adds format initialization for !bus and !bus->read/write. Format initialisation is skipped because it is not clear what the wire format actually is if we're not using the regmap internal marshalling. Someone needs to do a survey of what the existing users are trying to do before changing anything here. --O3bhLwMadv7h6/J9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVyyNqAAoJECTWi3JdVIfQ4LsH/1O1MyF+BG2ei9KHfOYXaihl zSoavMOGjvVCI8Qz2M7p+bXhhWS2T/5IQRq24pXu5zbXBtztNTZjjaiLknIpiSm5 Aa5F3IphJDhL166Kr9jEjPVVN7i3ufeC2Cs+oc5nICMiryWrFD3LueFrL49eVGdw ChX7alIU1JYIx5R0tMQhY0R1inWiuvvOFkINmyWGH2aEbyd4+wl1qZxTpwLDe/Tx ob8JEC275XK7qz4hJw8+Aphh+FjJ1D9RxRUkpbIRH5P04sMd1KkhkM45sA2UcIyr sI4XD7b0NZzJDDksUjx2/Ln2+nQFijcfu3HfDpH/hGx9Rfon3WKrT4jLcIZZUsQ= =hTM+ -----END PGP SIGNATURE----- --O3bhLwMadv7h6/J9-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/