Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752743AbbHLLTp (ORCPT ); Wed, 12 Aug 2015 07:19:45 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:38684 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750856AbbHLLTn (ORCPT ); Wed, 12 Aug 2015 07:19:43 -0400 Date: Wed, 12 Aug 2015 13:19:36 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: "Shah, Yash (Y.)" Cc: "mchehab@osg.samsung.com" , "gregkh@linuxfoundation.org" , "hans.verkuil@cisco.com" , "prabhakar.csengg@gmail.com" , "hamohammed.sa@gmail.com" , "luis@debethencourt.com" , "wsa@the-dreams.de" , "elfring@users.sourceforge.net" , "carlos@cgarcia.org" , "vthakkar1994@gmail.com" , "linux-media@vger.kernel.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , "Babu, Viswanathan (V.)" Subject: Re: [PATCH] Staging: media/bcm2048: Fix line over 80 characters warning as detected by checkpatch.pl Message-ID: <20150812111935.GA15037@pali> References: <20150812111245.GA24492@ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150812111245.GA24492@ubuntu> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1478 Lines: 35 On Wednesday 12 August 2015 11:12:49 Shah, Yash (Y.) wrote: > From: Yash Shah > > Fix line over 80 characters warning as detected by checkpatch.pl > > Signed-off-by: Yash Shah > --- > drivers/staging/media/bcm2048/radio-bcm2048.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c > index 8bc68e2..d36350e 100644 > --- a/drivers/staging/media/bcm2048/radio-bcm2048.c > +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c > @@ -2243,7 +2243,8 @@ static ssize_t bcm2048_fops_read(struct file *file, char __user *buf, > > tmpbuf[i] = bdev->rds_info.radio_text[bdev->rd_index+i+2]; > tmpbuf[i+1] = bdev->rds_info.radio_text[bdev->rd_index+i+1]; > - tmpbuf[i+2] = (bdev->rds_info.radio_text[bdev->rd_index + i] & 0xf0) >> 4; > + tmpbuf[i+2] = (bdev->rds_info.radio_text[bdev->rd_index + i] > + & 0xf0) >> 4; > if ((bdev->rds_info.radio_text[bdev->rd_index+i] & > BCM2048_RDS_CRC_MASK) == BCM2048_RDS_CRC_UNRECOVARABLE) > tmpbuf[i+2] |= 0x80; Hi! I think that code after this change is less readable as before. -- Pali Rohár pali.rohar@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/