Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751527AbbHLLli (ORCPT ); Wed, 12 Aug 2015 07:41:38 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:34547 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750767AbbHLLlh (ORCPT ); Wed, 12 Aug 2015 07:41:37 -0400 Message-ID: <55CB30EB.3050006@linaro.org> Date: Wed, 12 Aug 2015 12:41:31 +0100 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: maitysanchayan@gmail.com CC: gregkh@linuxfoundation.org, maxime.ripard@free-electrons.com, linux-arm-kernel@lists.infradead.org, stefan@agner.ch, shawnguo@kernel.org, kernel@pengutronix.de, stefan.wahren@i2se.com, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de Subject: Re: [PATCH v8 3/4] drivers: nvmem: Add Vybrid OCOTP support References: <29b527f1897b24a310a3f3acee61c721d3399503.1439214648.git.maitysanchayan@gmail.com> <55CB22F3.2000702@linaro.org> <20150812113203.GA15470@Sanchayan-Arch.toradex.int> In-Reply-To: <20150812113203.GA15470@Sanchayan-Arch.toradex.int> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1212 Lines: 34 On 12/08/15 12:32, maitysanchayan@gmail.com wrote: > Hello, > > On 15-08-12 11:41:55, Srinivas Kandagatla wrote: >> >Hi Sanchayan, >> > >> >Please run checkpatch before you send the patch next time. >> >Look at Documentation/SubmittingPatches for more details. >> > >> >WARNING: line over 80 characters >> >#225: FILE: drivers/nvmem/vf610-ocotp.c:174: >> >+ ret = vf610_ocotp_wait_busy(ocotp->base + OCOTP_CTRL_REG); >> > >> >WARNING: line over 80 characters >> >#237: FILE: drivers/nvmem/vf610-ocotp.c:186: >> >+ ret = vf610_ocotp_wait_busy(ocotp->base + OCOTP_CTRL_REG); >> > >> >WARNING: line over 80 characters >> >#244: FILE: drivers/nvmem/vf610-ocotp.c:193: >> >+ writel(OCOTP_CTRL_ERROR, ocotp->base + OCOTP_CTRL_CLR); >> > > I had. However splitting these lines seemed odd. Will split and fix. > Just get the base to a local variable, which should make it look neat and this will avoid de-referencing the octop in the all the time in loop. --srini -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/