Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755800AbbHLMk4 (ORCPT ); Wed, 12 Aug 2015 08:40:56 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:40447 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754155AbbHLMj2 (ORCPT ); Wed, 12 Aug 2015 08:39:28 -0400 Date: Wed, 12 Aug 2015 13:39:23 +0100 From: Mark Brown To: Markus Pargmann Cc: Jonathan Cameron , Srinivas Pandruvada , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Message-ID: <20150812123923.GI10748@sirena.org.uk> References: <1439374365-20623-1-git-send-email-mpa@pengutronix.de> <1439374365-20623-11-git-send-email-mpa@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8D3PigL67BfDl295" Content-Disposition: inline In-Reply-To: <1439374365-20623-11-git-send-email-mpa@pengutronix.de> X-Cookie: if it GLISTENS, gobble it!! User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 10/20] regmap: _regmap_raw_multi_reg_write: Add reg_write() support X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1421 Lines: 38 --8D3PigL67BfDl295 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 12, 2015 at 12:12:35PM +0200, Markus Pargmann wrote: > Define a fallback for busses which do not define a write() function. > Instead we write one register at a time using reg_write(). >=20 > Without this patch, _regmap_raw_multi_reg_write would break as it tries > to call bus->write() without checking if it exists before. Why are we trying to use multi write APIs in the first place if we can't do raw I/O? --8D3PigL67BfDl295 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVyz56AAoJECTWi3JdVIfQ8DcH/1QaD1LZS8pgnzT55iHMC6Nv cbn3xX8OPilN4NzZPgB5ZoLN/kWXZac+7hGYeuCZWOFLvVMFCAQRQD+GpPsn4n61 epn4c+/F214wfK1MJPmAZVIYW3YiC9cltJwhugvnkgvK7INAw/E8i9q39gb87nJf bUtKwiXIOimkc0CvkQg96OPrxCyyTAOs2bIwSCcrFCAv7ZTLg9BRDI9cTZOxCjXC PXnpiCp/mElzmFvDwxwStdpMgDraTMi3MQI2ZtB1b9cJope8bD9BG9CHhuDZEl9F w6Owknkll6q5+lzKqfP7w8QXgHdjbBjEw02H5WwzkPVKAEanWH6mY1Jls5FYWTw= =5mcj -----END PGP SIGNATURE----- --8D3PigL67BfDl295-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/