Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754320AbbHLNQM (ORCPT ); Wed, 12 Aug 2015 09:16:12 -0400 Received: from mx2.suse.de ([195.135.220.15]:48181 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752224AbbHLNQK (ORCPT ); Wed, 12 Aug 2015 09:16:10 -0400 Date: Wed, 12 Aug 2015 15:16:08 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Matthew Leach cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Sebastian Reichel , stable@vger.kernel.org Subject: Re: [PATCH] HID: hid-input: fix double-free in cleanup_battery In-Reply-To: <1439381384-13733-1-git-send-email-matthew@mattleach.net> Message-ID: References: <1439381384-13733-1-git-send-email-matthew@mattleach.net> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 739 Lines: 21 On Wed, 12 Aug 2015, Matthew Leach wrote: > The power supply layer has taken control of the power supply objects > from the drivers to core, see [1]. As such, calling > power_supply_unregister is enough to free the power_supply device. > > Remove the extra kfree's as the power_supply core will handle freeing > the power_supply object for us. Please see commit 0621809e37 ("HID: hid-input: Fix accessing freed memory during device disconnect") in Linus' tree. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/