Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754914AbbHLNeA (ORCPT ); Wed, 12 Aug 2015 09:34:00 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:38462 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754862AbbHLNd6 convert rfc822-to-8bit (ORCPT ); Wed, 12 Aug 2015 09:33:58 -0400 MIME-Version: 1.0 In-Reply-To: <20150812111935.GA15037@pali> References: <20150812111245.GA24492@ubuntu> <20150812111935.GA15037@pali> Date: Wed, 12 Aug 2015 15:33:55 +0200 Message-ID: Subject: Re: [PATCH] Staging: media/bcm2048: Fix line over 80 characters warning as detected by checkpatch.pl From: Frans Klaver To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: "Shah, Yash (Y.)" , "mchehab@osg.samsung.com" , "gregkh@linuxfoundation.org" , "hans.verkuil@cisco.com" , "prabhakar.csengg@gmail.com" , "hamohammed.sa@gmail.com" , "luis@debethencourt.com" , "wsa@the-dreams.de" , "elfring@users.sourceforge.net" , "carlos@cgarcia.org" , "vthakkar1994@gmail.com" , "linux-media@vger.kernel.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , "Babu, Viswanathan (V.)" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1763 Lines: 37 On Wed, Aug 12, 2015 at 1:19 PM, Pali Rohár wrote: > On Wednesday 12 August 2015 11:12:49 Shah, Yash (Y.) wrote: >> From: Yash Shah >> >> Fix line over 80 characters warning as detected by checkpatch.pl >> >> Signed-off-by: Yash Shah >> --- >> drivers/staging/media/bcm2048/radio-bcm2048.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c >> index 8bc68e2..d36350e 100644 >> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c >> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c >> @@ -2243,7 +2243,8 @@ static ssize_t bcm2048_fops_read(struct file *file, char __user *buf, >> >> tmpbuf[i] = bdev->rds_info.radio_text[bdev->rd_index+i+2]; >> tmpbuf[i+1] = bdev->rds_info.radio_text[bdev->rd_index+i+1]; >> - tmpbuf[i+2] = (bdev->rds_info.radio_text[bdev->rd_index + i] & 0xf0) >> 4; >> + tmpbuf[i+2] = (bdev->rds_info.radio_text[bdev->rd_index + i] >> + & 0xf0) >> 4; >> if ((bdev->rds_info.radio_text[bdev->rd_index+i] & >> BCM2048_RDS_CRC_MASK) == BCM2048_RDS_CRC_UNRECOVARABLE) >> tmpbuf[i+2] |= 0x80; > > Hi! I think that code after this change is less readable as before. I agree. I would do something about 'bdev->rds_info.radio_text' instead and shorten all three lines. Frans -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/