Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754793AbbHLNiL (ORCPT ); Wed, 12 Aug 2015 09:38:11 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:34223 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753162AbbHLNiI (ORCPT ); Wed, 12 Aug 2015 09:38:08 -0400 MIME-Version: 1.0 In-Reply-To: <55CB47D8.4010207@schinagl.nl> References: <55CB3D92.6040403@redhat.com> <55CB47D8.4010207@schinagl.nl> From: Michal Suchanek Date: Wed, 12 Aug 2015 15:37:27 +0200 Message-ID: Subject: Re: [linux-sunxi] [PATCH 3/3] mmc: sunxi: use controller automatic clock gating. To: Olliver Schinagl Cc: Hans de Goede , linux-sunxi , Seungwon Jeon , Jaehoon Chung , Ulf Hansson , Maxime Ripard , =?UTF-8?Q?David_Lanzend=C3=B6rfer?= , Chen-Yu Tsai , Arnd Bergmann , linux-mmc , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1348 Lines: 40 On 12 August 2015 at 15:19, Olliver Schinagl wrote: > Hey, > > On 12-08-15 14:35, Hans de Goede wrote: >> >> Hi, >> >> On 12-08-15 14:23, Michal Suchanek wrote: >>> >>> When core does not set the MMC_QUIRK_BROKEN_CLK_GATING flag enable >>> automatic hardware controlled clock gating on the mmc interface. >>> >>> Signed-off-by: Michal Suchanek >> >> >> In general this looks good, but I wonder how intensively this has >> been tested ? > > It doesn't matter actually, it took some time longer, but the mmc still > craps out even with Michal's 3 patches. I'll revert hans's earlier patch > again and do a bit more extensive testing. Does the oclk switch timeout even after 750ms? In some earlier tests I tried to enable/disable the clock repeatedly when it failed but it seemed to have little effect on the total time it took to disable the clock in the end. Maybe it would be worh trying to set the timeout to some insanely long value and test stability with that. I picked 750 as around twice the maximum time it ever took on my board. Thanks Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/