Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933329AbbHLNku (ORCPT ); Wed, 12 Aug 2015 09:40:50 -0400 Received: from mail.kernel.org ([198.145.29.136]:52326 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752924AbbHLNkt (ORCPT ); Wed, 12 Aug 2015 09:40:49 -0400 Date: Wed, 12 Aug 2015 10:40:42 -0300 From: Arnaldo Carvalho de Melo To: Masami Hiramatsu Cc: Namhyung Kim , Jiri Olsa , Linux Kernel Mailing List , David Ahern , Brendan Gregg Subject: Re: [BUGFIX PATCH perf/core ] perf-probe: Fix to show lines of sys_ functions correctly Message-ID: <20150812134042.GE31059@kernel.org> References: <50399556C9727B4D88A595C8584AAB37524B434C@GSjpTKYDCembx32.service.hitachi.net> <20150812012406.11811.94691.stgit@localhost.localdomain> <20150812132355.GD31059@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150812132355.GD31059@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2979 Lines: 80 Em Wed, Aug 12, 2015 at 10:23:55AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Aug 12, 2015 at 10:24:07AM +0900, Masami Hiramatsu escreveu: > > "perf probe --lines sys_poll" shows only the first line of > > sys_poll, because the SYSCALL_DEFINE macro > > ---- > Thanks! Just try prefixing those ---- lines one space so that git-am > works on your messages :-) > Now to build and test, will report here the results. Ok, now -L works: [root@zoo ~]# perf probe -L sys_select 0 SYSCALL_DEFINE5(select, int, n, fd_set __user *, inp, fd_set __user *, outp, fd_set __user *, exp, struct timeval __user *, tvp) { 3 struct timespec end_time, *to = NULL; struct timeval tv; int ret; 7 if (tvp) { 8 if (copy_from_user(&tv, tvp, sizeof(tv))) 9 return -EFAULT; 11 to = &end_time; 12 if (poll_select_set_timeout(to, tv.tv_sec + (tv.tv_usec / USEC_PER_SEC), 14 (tv.tv_usec % USEC_PER_SEC) * NSEC_PER_USEC)) 15 return -EINVAL; } 18 ret = core_sys_select(n, inp, outp, exp, to); 19 ret = poll_select_copy_remaining(&end_time, tvp, 1, ret); 21 return ret; } static long do_pselect(int n, fd_set __user *inp, fd_set __user *outp, But then adding a probe doesn't work on sys_select, even with -L stating that I can add a probe at that line, maybe the code you added to make -L work needs to be shared with the other operations in 'perf probe'? [root@zoo ~]# [root@zoo ~]# perf probe 'get_timeval=sys_select:11 tv_sec=tv.tv_sec tv_usec=tv.tv_usec' Probe point 'sys_select:11' not found. Error: Failed to add events. [root@zoo ~]# [root@zoo ~]# perf probe -V sys_select Available variables at sys_select @ long int exp long int inp long int n long int outp long int tvp [root@zoo ~]# perf probe -V sys_select:11 Failed to find the address of sys_select:11 Error: Failed to show vars. [root@zoo ~]# While this works: [root@zoo ~]# perf probe 'vfs_getname=getname_flags:72 pathname=filename:string' Added new event: probe:vfs_getname (on getname_flags:72 with pathname=filename:string) You can now use it in all perf tools, such as: perf record -e probe:vfs_getname -aR sleep 1 - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/