Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932401AbbHLO5d (ORCPT ); Wed, 12 Aug 2015 10:57:33 -0400 Received: from 7of9.schinagl.nl ([88.159.158.68]:47231 "EHLO 7of9.schinagl.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932080AbbHLO5b (ORCPT ); Wed, 12 Aug 2015 10:57:31 -0400 Message-ID: <55CB5ED7.40406@schinagl.nl> Date: Wed, 12 Aug 2015 16:57:27 +0200 From: Olliver Schinagl User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: hramrach@gmail.com CC: Hans de Goede , linux-sunxi , Seungwon Jeon , Jaehoon Chung , Ulf Hansson , Maxime Ripard , =?UTF-8?B?RGF2aWQgTGFuemVuZMO2cmZlcg==?= , Chen-Yu Tsai , Arnd Bergmann , linux-mmc , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" Subject: Re: [linux-sunxi] [PATCH 3/3] mmc: sunxi: use controller automatic clock gating. References: <55CB3D92.6040403@redhat.com> <55CB47D8.4010207@schinagl.nl> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1938 Lines: 52 The thing is, I never saw the prints in my console (i assume that it prints on the console by default with earlyprintk/debug stuff enabled as per sunxi-usual)? P.S. what I do as a basic test, is on our very very minimal empty debian image (think < 150 mb) i do a apt-get build-essential that installs about 150mb worth of packages. Without these patches, everything works as before. All packages successfully installed. I can do more intense testing later, but I figured that this is pretty intense. Olliver On 12-08-15 15:37, Michal Suchanek wrote: > On 12 August 2015 at 15:19, Olliver Schinagl wrote: >> Hey, >> >> On 12-08-15 14:35, Hans de Goede wrote: >>> Hi, >>> >>> On 12-08-15 14:23, Michal Suchanek wrote: >>>> When core does not set the MMC_QUIRK_BROKEN_CLK_GATING flag enable >>>> automatic hardware controlled clock gating on the mmc interface. >>>> >>>> Signed-off-by: Michal Suchanek >>> >>> In general this looks good, but I wonder how intensively this has >>> been tested ? >> It doesn't matter actually, it took some time longer, but the mmc still >> craps out even with Michal's 3 patches. I'll revert hans's earlier patch >> again and do a bit more extensive testing. > Does the oclk switch timeout even after 750ms? > > In some earlier tests I tried to enable/disable the clock repeatedly > when it failed but it seemed to have little effect on the total time > it took to disable the clock in the end. > > Maybe it would be worh trying to set the timeout to some insanely long > value and test stability with that. I picked 750 as around twice the > maximum time it ever took on my board. > > Thanks > > Michal > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/