Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933575AbbHLPvO (ORCPT ); Wed, 12 Aug 2015 11:51:14 -0400 Received: from mail-db3on0099.outbound.protection.outlook.com ([157.55.234.99]:52672 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932065AbbHLPvJ (ORCPT ); Wed, 12 Aug 2015 11:51:09 -0400 From: Noam Camus To: Peter Hurley CC: "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" , "gregkh@linuxfoundation.org" , "jslaby@suse.com" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "@codeaurora.orggalak@codeaurora.org" , "fransklaver@gmail.com" , "Alexey.Brodkin@synopsys.com" , "vgupta@synopsys.com" Subject: RE: [v3 3/3] serial: 8250_dw: Add UPF_SKIP_TEST to flags depend on device tree Thread-Topic: [v3 3/3] serial: 8250_dw: Add UPF_SKIP_TEST to flags depend on device tree Thread-Index: AQHQ1PDlm3Sx1nkzPkKuBQ/Nd53nop4IWGcAgAAgOrA= Date: Wed, 12 Aug 2015 15:51:05 +0000 Message-ID: References: <1437886478-29273-1-git-send-email-noamc@ezchip.com> <1439378312-6463-1-git-send-email-noamc@ezchip.com> <1439378312-6463-2-git-send-email-noamc@ezchip.com> <1439378312-6463-3-git-send-email-noamc@ezchip.com> <1439378312-6463-4-git-send-email-noamc@ezchip.com> <55CB4740.7070703@hurleysoftware.com> In-Reply-To: <55CB4740.7070703@hurleysoftware.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=noamc@ezchip.com; x-originating-ip: [212.179.42.66] x-microsoft-exchange-diagnostics: 1;DB4PR02MB271;5:aS09edJoHSFSFipo5CPEveLIgrSozj+TXy2gsbQ1APNAffhc9hGt1WpxwKZcryie7GVeiLIUCb4n/bG12EAEYXi7/0onVcqBqFWcx9FgupL2bByYTZyR0PIVWmp255yGYQfVFJ4A7QMajdYkyR4mHg==;24:d0st0t4PvHA46G7rEiYJwcs6WHL/NUS8r0frvyBUI3pAtM3mXgsXWgh7/WvFMwXgM3K60ldVGM5QNTVfWV4rClizonimMILig+hYQC3+NXw=;20:bSGtlpRfddDH/9PqIyQhW0SxLjXh9AVCulh9KcOlNIf2wYqG49Pms4tbEWK+Hv/hIk42Q3q5GYmqmH13tv3pBQ== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB4PR02MB271; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:DB4PR02MB271;BCL:0;PCL:0;RULEID:;SRVR:DB4PR02MB271; x-forefront-prvs: 0666E15D35 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(189002)(377454003)(199003)(5002640100001)(102836002)(5001860100001)(40100003)(77096005)(62966003)(77156002)(189998001)(66066001)(68736005)(4001540100001)(54356999)(2950100001)(93886004)(2900100001)(92566002)(5001830100001)(97736004)(33656002)(74316001)(122556002)(87936001)(81156007)(50986999)(19580395003)(46102003)(76176999)(64706001)(19580405001)(76576001)(106356001)(5003600100002)(101416001)(10400500002)(110136002)(106116001)(2656002)(86362001)(105586002)(5001960100002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR02MB271;H:DB4PR02MB272.eurprd02.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2015 15:51:06.0089 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0fc16e0a-3cd3-4092-8b2f-0a42cff122c3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR02MB271 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t7CFpMTN019660 Content-Length: 1161 Lines: 22 > From: Peter Hurley [mailto:peter@hurleysoftware.com] > Sent: Wednesday, August 12, 2015 4:17 PM > I think Greg's question about the simulator still applies: why upstream this? > The simulator is not even identified so how is someone supposed to know this workaround applies? > The fact there are no in-tree DT users of this workaround argues against its acceptance. I am using UART peripheral for Synopsys simulator same as one used by arch/arc/plat-sim I know this platform do not use CONFIG_SERIAL_8250_DW due to some problem I suspect it is relate to the loop test. Maybe Vineet Gupta or Alexey Brodkin from Synopsys which are CC here can comment. So It just happen for me to be a pioneer with this. More than that "no-loopback-test" is an option already exist for core 8250, and since DW is only an extension for this driver it should also benefit from this option. If all this is yet not enough, should I re-send this "patch set" again without this specific patch? Regards, Noam Camus ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?