Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933706AbbHLQ1M (ORCPT ); Wed, 12 Aug 2015 12:27:12 -0400 Received: from mail-ig0-f181.google.com ([209.85.213.181]:34146 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932114AbbHLQ1I (ORCPT ); Wed, 12 Aug 2015 12:27:08 -0400 MIME-Version: 1.0 In-Reply-To: <1439363150-8661-32-git-send-email-hch@lst.de> References: <1439363150-8661-1-git-send-email-hch@lst.de> <1439363150-8661-32-git-send-email-hch@lst.de> From: Catalin Marinas Date: Wed, 12 Aug 2015 17:26:44 +0100 Message-ID: Subject: Re: [PATCH 31/31] dma-mapping-common: skip kmemleak checks for page-less SG entries To: Christoph Hellwig Cc: Linus Torvalds , axboe@kernel.dk, Dan Williams , vgupta@synopsys.com, hskinnemoen@gmail.com, egtvedt@samfundet.no, realmz6@gmail.com, David Howells , Michal Simek , "x86@kernel.org" , David Woodhouse , alex.williamson@redhat.com, grundler@parisc-linux.org, Linux Kernel Mailing List , "linux-arch@vger.kernel.org" , linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, linux-metag@vger.kernel.org, linux-mips@linux-mips.org, linux-parisc@vger.kernel.org, "linuxppc-dev@lists.ozlabs.org" , "linux-s390@vger.kernel.org" , sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-nvdimm@ml01.01.org, Linux Media Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1268 Lines: 33 Christoph, On 12 August 2015 at 08:05, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > include/asm-generic/dma-mapping-common.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/include/asm-generic/dma-mapping-common.h b/include/asm-generic/dma-mapping-common.h > index 940d5ec..afc3eaf 100644 > --- a/include/asm-generic/dma-mapping-common.h > +++ b/include/asm-generic/dma-mapping-common.h > @@ -51,8 +51,10 @@ static inline int dma_map_sg_attrs(struct device *dev, struct scatterlist *sg, > int i, ents; > struct scatterlist *s; > > - for_each_sg(sg, s, nents, i) > - kmemcheck_mark_initialized(sg_virt(s), s->length); > + for_each_sg(sg, s, nents, i) { > + if (sg_has_page(s)) > + kmemcheck_mark_initialized(sg_virt(s), s->length); > + } Just a nitpick for the subject, it should say "kmemcheck" rather than "kmemleak" (different features ;)). -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/