Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933919AbbHLQ1o (ORCPT ); Wed, 12 Aug 2015 12:27:44 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:38598 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932114AbbHLQ1m convert rfc822-to-8bit (ORCPT ); Wed, 12 Aug 2015 12:27:42 -0400 MIME-Version: 1.0 In-Reply-To: <1439389332-9373-1-git-send-email-mike.looijmans@topic.nl> References: <1439389332-9373-1-git-send-email-mike.looijmans@topic.nl> Date: Wed, 12 Aug 2015 09:27:40 -0700 Message-ID: Subject: Re: [PATCH] pinctrl-zynq.c: Fix typos in smc0_nand_grp and smc0_nor_grp From: Moritz Fischer To: Mike Looijmans Cc: linux-gpio@vger.kernel.org, Linus Walleij , linux-kernel@vger.kernel.org, Michal Simek , linux-arm-kernel , =?UTF-8?Q?S=C3=B6ren_Brinkmann?= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2195 Lines: 45 Acked-by: Moritz Fischer On Wed, Aug 12, 2015 at 7:22 AM, Mike Looijmans wrote: > Group names should be smc0_nand_grp and smc0_nor_grp, otherwise you'll > get errors like this if you try to pinmux them via the devicetree: > zynq-pinctrl 700.pinctrl: invalid group "smc0_nand_grp" for function "smc0_nand" > > Probably a typo while creating these tables. > > Signed-off-by: Mike Looijmans > Acked-by: Sören Brinkmann > --- > drivers/pinctrl/pinctrl-zynq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c > index 7ce23b6..5aafea8 100644 > --- a/drivers/pinctrl/pinctrl-zynq.c > +++ b/drivers/pinctrl/pinctrl-zynq.c > @@ -706,10 +706,10 @@ static const char * const sdio1_wp_groups[] = {"gpio0_0_grp", > "gpio0_39_grp", "gpio0_41_grp", "gpio0_43_grp", > "gpio0_45_grp", "gpio0_47_grp", "gpio0_49_grp", > "gpio0_51_grp", "gpio0_53_grp", "sdio1_emio_wp_grp"}; > -static const char * const smc0_nor_groups[] = {"smc0_nor"}; > +static const char * const smc0_nor_groups[] = {"smc0_nor_grp"}; > static const char * const smc0_nor_cs1_groups[] = {"smc0_nor_cs1_grp"}; > static const char * const smc0_nor_addr25_groups[] = {"smc0_nor_addr25_grp"}; > -static const char * const smc0_nand_groups[] = {"smc0_nand"}; > +static const char * const smc0_nand_groups[] = {"smc0_nand_grp"}; > static const char * const can0_groups[] = {"can0_0_grp", "can0_1_grp", > "can0_2_grp", "can0_3_grp", "can0_4_grp", "can0_5_grp", > "can0_6_grp", "can0_7_grp", "can0_8_grp", "can0_9_grp", > -- > 1.9.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/