Date: Wed, 12 Aug 2015 19:07:16 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Vince Weaver <vincent.weaver@maine.edu>
Cc: mingo@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org,
        hpa@zytor.com, torvalds@linux-foundation.org,
        linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] perf: Fix PERF_EVENT_IOC_PERIOD migration race
Message-ID: <20150812170716.GV16853@twins.programming.kicks-ass.net>
References: <tip-c7999c6f3fed9e383d3131474588f282ae6d56b9@git.kernel.org>
 <alpine.DEB.2.20.1508120947360.24663@vincent-weaver-1.umelst.maine.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.20.1508120947360.24663@vincent-weaver-1.umelst.maine.edu>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1232
Lines: 33

On Wed, Aug 12, 2015 at 09:49:40AM -0400, Vince Weaver wrote:
> On Wed, 12 Aug 2015, tip-bot for Peter Zijlstra wrote:
> 
> > Commit-ID:  c7999c6f3fed9e383d3131474588f282ae6d56b9
> > Gitweb:     http://git.kernel.org/tip/c7999c6f3fed9e383d3131474588f282ae6d56b9
> > Author:     Peter Zijlstra <peterz@infradead.org>
> > AuthorDate: Tue, 4 Aug 2015 19:22:49 +0200
> > Committer:  Ingo Molnar <mingo@kernel.org>
> > CommitDate: Wed, 12 Aug 2015 11:37:22 +0200
> > 
> > perf: Fix PERF_EVENT_IOC_PERIOD migration race
> > 
> > I ran the perf fuzzer, which triggered some WARN()s which are due to
> > trying to stop/restart an event on the wrong CPU.
> 
> Do you have a list of which WARNs this should fix?  Just so I can 
> update my bug tracker.

I think this triggered:

arch/x86/kernel/cpu/perf_event.c:x86_pmu_del()

	if (WARN_ON_ONCE(i == cpuc->n_events)) /* called ->del() without ->add() ? */


Through perf_ioctl()->perf_event_period().

I didn't safe a copy of the exact backtrace.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/