Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751748AbbHLTNA (ORCPT ); Wed, 12 Aug 2015 15:13:00 -0400 Received: from mx2.suse.de ([195.135.220.15]:53046 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751137AbbHLTM7 (ORCPT ); Wed, 12 Aug 2015 15:12:59 -0400 Subject: Re: [PATCH] kvm:powerpc:Fix incorrect return statement in the function mpic_set_default_irq_routing To: nick , gleb@kernel.org References: <1438962893-3370-1-git-send-email-xerofoify@gmail.com> <55CB98FE.4060908@suse.de> <55CB9942.7050303@gmail.com> Cc: linuxppc-dev@lists.ozlabs.org, pbonzini@redhat.com, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org From: Alexander Graf Message-ID: <55CB9AB8.9000104@suse.de> Date: Wed, 12 Aug 2015 21:12:56 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <55CB9942.7050303@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1275 Lines: 40 On 12.08.15 21:06, nick wrote: > > > On 2015-08-12 03:05 PM, Alexander Graf wrote: >> >> >> On 07.08.15 17:54, Nicholas Krause wrote: >>> This fixes the incorrect return statement in the function >>> mpic_set_default_irq_routing from always returning zero >>> to signal success to this function's caller to instead >>> return the return value of kvm_set_irq_routing as this >>> function can fail and we need to correctly signal the >>> caller of mpic_set_default_irq_routing when the call >>> to this particular function has failed. >>> >>> Signed-off-by: Nicholas Krause >> >> I like the patch, but I don't see it on the kvm-ppc mailing list. It >> doesn't show up on patchwork or spinics. Did something go wrong while >> sending it out? >> >> >> Alex >> > Alex, > Ask Paolo about it as he would be able to explain it better then I. Well, whatever the reason, I can only apply patches that actually appeared on the public mailing list. Otherwise people may not get the chance to review them ;). Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/