Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752108AbbHLTao (ORCPT ); Wed, 12 Aug 2015 15:30:44 -0400 Received: from mail-gw1-out.broadcom.com ([216.31.210.62]:60990 "EHLO mail-gw1-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751926AbbHLTan (ORCPT ); Wed, 12 Aug 2015 15:30:43 -0400 X-IronPort-AV: E=Sophos;i="5.15,663,1432623600"; d="scan'208";a="72439983" Message-ID: <55CB9ED5.1010809@broadcom.com> Date: Wed, 12 Aug 2015 12:30:29 -0700 From: Scott Branden User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Daniel Lezcano , CC: , , Viresh Kumar , Florian Fainelli , Ray Jui , Subject: Re: [PATCH 04/74] clockevents/drivers/bcm_kona: Migrate to new 'set-state' interface References: <55C87382.4070309@linaro.org> <1439200352-26767-1-git-send-email-daniel.lezcano@linaro.org> <1439200352-26767-4-git-send-email-daniel.lezcano@linaro.org> In-Reply-To: <1439200352-26767-4-git-send-email-daniel.lezcano@linaro.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2383 Lines: 68 Looks good, thanks. On 15-08-10 02:51 AM, Daniel Lezcano wrote: > From: Viresh Kumar > > Migrate bcm_kona driver to the new 'set-state' interface provided by > the clockevents core, the earlier 'set-mode' interface is marked > obsolete now. > > This also enables us to implement callbacks for new states of clockevent > devices, for example: ONESHOT_STOPPED. > > Oneshot callback isn't required as it was empty. > > Acked-by: Ray Jui Acked-by; Scott Branden > Cc: Florian Fainelli > Cc: Ray Jui > Cc: Scott Branden > Cc: bcm-kernel-feedback-list@broadcom.com > Signed-off-by: Viresh Kumar > Signed-off-by: Daniel Lezcano > --- > drivers/clocksource/bcm_kona_timer.c | 17 +++++------------ > 1 file changed, 5 insertions(+), 12 deletions(-) > > diff --git a/drivers/clocksource/bcm_kona_timer.c b/drivers/clocksource/bcm_kona_timer.c > index f1e33d0..e717e87 100644 > --- a/drivers/clocksource/bcm_kona_timer.c > +++ b/drivers/clocksource/bcm_kona_timer.c > @@ -127,25 +127,18 @@ static int kona_timer_set_next_event(unsigned long clc, > return 0; > } > > -static void kona_timer_set_mode(enum clock_event_mode mode, > - struct clock_event_device *unused) > +static int kona_timer_shutdown(struct clock_event_device *evt) > { > - switch (mode) { > - case CLOCK_EVT_MODE_ONESHOT: > - /* by default mode is one shot don't do any thing */ > - break; > - case CLOCK_EVT_MODE_UNUSED: > - case CLOCK_EVT_MODE_SHUTDOWN: > - default: > - kona_timer_disable_and_clear(timers.tmr_regs); > - } > + kona_timer_disable_and_clear(timers.tmr_regs); > + return 0; > } > > static struct clock_event_device kona_clockevent_timer = { > .name = "timer 1", > .features = CLOCK_EVT_FEAT_ONESHOT, > .set_next_event = kona_timer_set_next_event, > - .set_mode = kona_timer_set_mode > + .set_state_shutdown = kona_timer_shutdown, > + .tick_resume = kona_timer_shutdown, > }; > > static void __init kona_timer_clockevents_init(void) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/