From: =?iso-2022-jp?B?GyRCSj8+PjJtTCYbKEIgLyBISVJBTUFUVRskQiEkGyhCTUFTQU1J?= 
	<masami.hiramatsu.pt@hitachi.com>
To: "'Arnaldo Carvalho de Melo'" <acme@kernel.org>
CC: Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        David Ahern <dsahern@gmail.com>,
        Brendan Gregg <brendan.d.gregg@gmail.com>
Subject: Re: [BUGFIX PATCH perf/core ] perf-probe: Fix to show lines of sys_
 functions correctly
Thread-Topic: [BUGFIX PATCH perf/core ] perf-probe: Fix to show lines of
 sys_ functions correctly
Thread-Index: AQHQ1J4+BSZ1JMeCUkSg21PjFJi/JJ4HxCmAgAAEsQCAARn3EA==
Date: Wed, 12 Aug 2015 21:37:34 +0000
Message-ID: <50399556C9727B4D88A595C8584AAB37524B7E26@GSjpTKYDCembx32.service.hitachi.net>
References: <50399556C9727B4D88A595C8584AAB37524B434C@GSjpTKYDCembx32.service.hitachi.net>
 <20150812012406.11811.94691.stgit@localhost.localdomain>
 <20150812132355.GD31059@kernel.org> <20150812134042.GE31059@kernel.org>
In-Reply-To: <20150812134042.GE31059@kernel.org>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2241
Lines: 57

> From: Arnaldo Carvalho de Melo [mailto:acme@kernel.org]
> 
> Em Wed, Aug 12, 2015 at 10:23:55AM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Wed, Aug 12, 2015 at 10:24:07AM +0900, Masami Hiramatsu escreveu:
> > > "perf probe --lines sys_poll" shows only the first line of
> > > sys_poll, because the SYSCALL_DEFINE macro
> > > ----
> 
> > Thanks! Just try prefixing those ---- lines one space so that git-am
> > works on your messages :-)
> 
> > Now to build and test, will report here the results.
> 
> Ok, now -L works:
> 
>   [root@zoo ~]# perf probe -L sys_select
>   <SyS_select@/home/git/linux/fs/select.c:0>
>       0  SYSCALL_DEFINE5(select, int, n, fd_set __user *, inp, fd_set __user *, outp,
>                         fd_set __user *, exp, struct timeval __user *, tvp)
>          {
>       3         struct timespec end_time, *to = NULL;
>                 struct timeval tv;
>                 int ret;
> 
>       7         if (tvp) {
>       8                 if (copy_from_user(&tv, tvp, sizeof(tv)))
>       9                         return -EFAULT;
> 
>      11                 to = &end_time;
>      12                 if (poll_select_set_timeout(to,
>                                         tv.tv_sec + (tv.tv_usec / USEC_PER_SEC),
>      14                                 (tv.tv_usec % USEC_PER_SEC) * NSEC_PER_USEC))
>      15                         return -EINVAL;
>                 }
> 
>      18         ret = core_sys_select(n, inp, outp, exp, to);
>      19         ret = poll_select_copy_remaining(&end_time, tvp, 1, ret);
> 
>      21         return ret;
>          }
> 
>          static long do_pselect(int n, fd_set __user *inp, fd_set __user *outp,
> 
> But then adding a probe doesn't work on sys_select, even with -L stating that I
> can add a probe at that line, maybe the code you added to make -L work needs to
> be shared with the other operations in 'perf probe'?

Oops, I missed a {} around new if statement...
I'll update the patch asap.

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/