Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751955AbbHLWfs (ORCPT ); Wed, 12 Aug 2015 18:35:48 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:51216 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751093AbbHLWfG (ORCPT ); Wed, 12 Aug 2015 18:35:06 -0400 MIME-Version: 1.0 In-Reply-To: <1438894770-31163-2-git-send-email-al.stone@linaro.org> References: <1438894770-31163-1-git-send-email-al.stone@linaro.org> <1438894770-31163-2-git-send-email-al.stone@linaro.org> Date: Wed, 12 Aug 2015 17:35:04 -0500 Message-ID: Subject: Re: [Linaro-acpi] [PATCH 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro From: Timur Tabi To: Al Stone Cc: linux-acpi@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , linaro-kernel@lists.linaro.org, linux-ia64@vger.kernel.org, patches@linaro.org, linux-pm@vger.kernel.org, linaro-acpi@lists.linaro.org, "Rafael J. Wysocki" , lkml , Len Brown Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 822 Lines: 25 On Thu, Aug 6, 2015 at 3:59 PM, Al Stone wrote: > + while (ms->num_types != 0) { > + if (ms->major_version == major && > + ms->minor_version == minor && > + ms->madt_version == madt->header.revision) > + break; > + ms++; > + } > + if (!ms) { Shouldn't this be if (!ms->num_types) { instead? -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/