Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751977AbbHMAz3 (ORCPT ); Wed, 12 Aug 2015 20:55:29 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:32835 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751732AbbHMAz2 (ORCPT ); Wed, 12 Aug 2015 20:55:28 -0400 Date: Thu, 13 Aug 2015 09:55:25 +0900 From: Simon Horman To: Minfei Huang , akpm@linux-foundation.org Cc: vgoyal@redhat.com, ebiederm@xmission.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic Message-ID: <20150813005525.GB7852@verge.net.au> References: <1438058802-6462-1-git-send-email-mnfhuang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438058802-6462-1-git-send-email-mnfhuang@gmail.com> Organisation: Horms Solutions Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1555 Lines: 47 On Tue, Jul 28, 2015 at 12:46:42PM +0800, Minfei Huang wrote: > Transforming PFN(Page Frame Number) to struct page is never failure, so > we can simplify the code logic to do the image->control_page assignment > directly in the loop, and remove the unnecessary conditional judgement. > > Signed-off-by: Minfei Huang > Acked-by: Dave Young > Acked-by: Vivek Goyal Andrew, could you consider picking this up. It seems to have been sufficiently reviewed, acked, etc... > --- > kernel/kexec.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/kernel/kexec.c b/kernel/kexec.c > index 6f1ed75..cf82474 100644 > --- a/kernel/kexec.c > +++ b/kernel/kexec.c > @@ -807,11 +807,10 @@ static struct page *kimage_alloc_crash_control_pages(struct kimage *image, > /* If I don't overlap any segments I have found my hole! */ > if (i == image->nr_segments) { > pages = pfn_to_page(hole_start >> PAGE_SHIFT); > + image->control_page = hole_end; > break; > } > } > - if (pages) > - image->control_page = hole_end; > > return pages; > } > -- > 2.4.0 > > > _______________________________________________ > kexec mailing list > kexec@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/