Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752082AbbHMH5j (ORCPT ); Thu, 13 Aug 2015 03:57:39 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:33261 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751852AbbHMH5i (ORCPT ); Thu, 13 Aug 2015 03:57:38 -0400 Date: Thu, 13 Aug 2015 16:57:32 +0900 From: Simon Horman To: Baoquan He Cc: Minfei Huang , akpm@linux-foundation.org, kexec@lists.infradead.org, ebiederm@xmission.com, vgoyal@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic Message-ID: <20150813075730.GA4325@verge.net.au> References: <1438058802-6462-1-git-send-email-mnfhuang@gmail.com> <20150813005525.GB7852@verge.net.au> <20150813055345.GC26247@dhcp-128-28.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150813055345.GC26247@dhcp-128-28.nay.redhat.com> Organisation: Horms Solutions Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1241 Lines: 32 On Thu, Aug 13, 2015 at 01:53:45PM +0800, Baoquan He wrote: > On 08/13/15 at 09:55am, Simon Horman wrote: > > On Tue, Jul 28, 2015 at 12:46:42PM +0800, Minfei Huang wrote: > > > Transforming PFN(Page Frame Number) to struct page is never failure, so > > > we can simplify the code logic to do the image->control_page assignment > > > directly in the loop, and remove the unnecessary conditional judgement. > > > > > > Signed-off-by: Minfei Huang > > > Acked-by: Dave Young > > > Acked-by: Vivek Goyal > > > > Andrew, could you consider picking this up. > > It seems to have been sufficiently reviewed, acked, etc... > > I saw this has been in linux-next tree. Excellent, sorry for the noise. > commit b90b6ef0f152ef42fe66ce5c9ccf2783ea84fa69 > Author: Minfei Huang > Date: Thu Jul 30 09:56:18 2015 +1000 > > kexec: remove unnecessary test in kimage_alloc_crash_control_pages() > > Thanks > Baoquan > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/