Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751931AbbHMIt3 (ORCPT ); Thu, 13 Aug 2015 04:49:29 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:45106 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751282AbbHMItY (ORCPT ); Thu, 13 Aug 2015 04:49:24 -0400 X-AuditID: cbfee68f-f793b6d000005f66-4b-55cc5a12c8d5 From: Joonyoung Shim To: rtc-linux@googlegroups.com Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, sbkim73@samsung.com, k.kozlowski@samsung.com, jy0922.shim@samsung.com Subject: [PATCH] rtc: s5m: fix to update ctrl register Date: Thu, 13 Aug 2015 17:49:24 +0900 Message-id: <1439455764-23526-1-git-send-email-jy0922.shim@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrLLMWRmVeSWpSXmKPExsWyRsSkQFco6kyowYVmSYslF6+yW3RcW8xk 8eLeRRaL1y8MLS7vmsNmMeP8PiaL/Z0djBYXV3xhsliw8RGjA6fHk00XGT32TDzJ5tG3ZRWj x/R5P5k8Pm+SC2CN4rJJSc3JLEst0rdL4MrYduAKc8EkzopnzeuYGxh3s3cxcnJICJhIdJ38 zARhi0lcuLeerYuRi0NIYAWjxO61x+CKvq9shErMYpT49uk8M4Tzg1HiZtdKsHY2AT2JO9uO g9kiAnISNw++YwIpYhZ4wihx8d5qRpCEsICZxNLmJjYQm0VAVaLp418wm1fAXWJh20WoO+Qk Th6bzAph97NLPPwVDlEvIPFt8iGWLkYOoLisxKYDzBAlkhIHV9xgmcAouICRYRWjaGpBckFx UnqRsV5xYm5xaV66XnJ+7iZGYCif/vesfwfj3QPWhxgFOBiVeHg3PDodKsSaWFZcmXuI0RRo w0RmKdHkfGDE5JXEGxqbGVmYmpgaG5lbmimJ8y6U+hksJJCeWJKanZpakFoUX1Sak1p8iJGJ g1OqgXFukUfz+qt3z1/x+ynbrhHNGfLj0eb5j60/OTFEZ5q4X7e14Ov9upRfuT59iV9Iw9qz XySWJua/OfJs2xmRcK1rB9mWzAs8JlFt/mx6VsJn9TTDzpquCl2OzDaHsO/hVZyNF2on7EpK ehe56ojYM+Hg46b34qbanfuQf05vcvPf8pCAGtbNV5RYijMSDbWYi4oTATFbDSRgAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNIsWRmVeSWpSXmKPExsVy+t9jQV2hqDOhBtO+CFssuXiV3aLj2mIm ixf3LrJYvH5haHF51xw2ixnn9zFZ7O/sYLS4uOILk8WCjY8YHTg9nmy6yOixZ+JJNo++LasY PabP+8nk8XmTXABrVAOjTUZqYkpqkUJqXnJ+SmZeuq2Sd3C8c7ypmYGhrqGlhbmSQl5ibqqt kotPgK5bZg7QQUoKZYk5pUChgMTiYiV9O0wTQkPcdC1gGiN0fUOC4HqMDNBAwhrGjG0HrjAX TOKseNa8jrmBcTd7FyMnh4SAicT3lY1sELaYxIV764FsLg4hgVmMEt8+nWeGcH4wStzsWskE UsUmoCdxZ9txMFtEQE7i5sF3TCBFzAJPGCUu3lvNCJIQFjCTWNrcBDaWRUBVounjXzCbV8Bd YmHbRSaIdXISJ49NZp3AyL2AkWEVo0RqQXJBcVJ6rmFearlecWJucWleul5yfu4mRnDEPJPa wXhwl/shRgEORiUe3g2PTocKsSaWFVfmHmKU4GBWEuE9KncmVIg3JbGyKrUoP76oNCe1+BCj KdABE5mlRJPzgdGcVxJvaGxiZmRpZG5oYWRsriTOK7thc6iQQHpiSWp2ampBahFMHxMHp1QD 48SL63aqncqwNbzPatK/KOyq+KsTC6UqDr0UOXlJ6mSJFG/ahVDuyCvvxP8911/Q9rTs8vTT l2b6Fepr9koXnUw6u//qyRWFX5RCm5WOs2woDuqWezdr06weN+8FTwrUXMLql+xq3JQWtyxr 4fPw3DfLLmXONjjXbvcz3UHFKLpjq3PmUwMLayWW4oxEQy3mouJEAMVin02uAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1376 Lines: 44 According to datasheet, the S2MPS13X and S2MPS14X should update write buffer via setting WUDR bit to high after ctrl register is updated. If not, ALARM interrupt of rtc-s5m doesn't happen first time when i use tools/testing/selftests/timers/rtctest.c test program and hour format is used to 12 hour mode in Odroid-XU3 board. Signed-off-by: Joonyoung Shim Cc: --- drivers/rtc/rtc-s5m.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index 8c70d78..03828bb 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -635,6 +635,18 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info) case S2MPS13X: data[0] = (0 << BCD_EN_SHIFT) | (1 << MODEL24_SHIFT); ret = regmap_write(info->regmap, info->regs->ctrl, data[0]); + if (ret < 0) + break; + + ret = regmap_update_bits(info->regmap, + info->regs->rtc_udr_update, + info->regs->rtc_udr_mask, + info->regs->rtc_udr_mask); + if (ret < 0) + break; + + ret = s5m8767_wait_for_udr_update(info); + break; default: -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/