Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752612AbbHMJ32 (ORCPT ); Thu, 13 Aug 2015 05:29:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52001 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752537AbbHMJ3Z (ORCPT ); Thu, 13 Aug 2015 05:29:25 -0400 Subject: Re: [PATCH v2 1/5] KVM: add kvm_has_request wrapper To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Christian Borntraeger References: <1438792381-19453-1-git-send-email-rkrcmar@redhat.com> <1438792381-19453-2-git-send-email-rkrcmar@redhat.com> <55CBA523.3010007@de.ibm.com> <20150813091110.GA26977@potion.brq.redhat.com> Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org From: Paolo Bonzini Message-ID: <55CC6370.3080606@redhat.com> Date: Thu, 13 Aug 2015 11:29:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20150813091110.GA26977@potion.brq.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 858 Lines: 29 On 13/08/2015 11:11, Radim Krčmář wrote: >> > for the new interface. maybe we can rename kvm_check_request in a separate patch somewhen. > I wonder why haven't we copied the naming convention from bit operations > (or if programming would be better if German was its language), > > kvm_test_request > kvm_set_request > kvm_clear_request > kvm_test_and_clear_request > > The only disadvantage is that > kvm_test_and_clear_request > is longer than > kvm_check_request > 123456789 > by whooping 9 characters. > > I could live with that. Yes, that would be much better. Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/