Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752623AbbHMKD2 (ORCPT ); Thu, 13 Aug 2015 06:03:28 -0400 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:34020 "EHLO e06smtp17.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751877AbbHMKD1 (ORCPT ); Thu, 13 Aug 2015 06:03:27 -0400 X-Helo: d06dlp01.portsmouth.uk.ibm.com X-MailFrom: borntraeger@de.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Message-ID: <55CC6B68.9090903@de.ibm.com> Date: Thu, 13 Aug 2015 12:03:20 +0200 From: Christian Borntraeger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= CC: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v2 1/5] KVM: add kvm_has_request wrapper References: <1438792381-19453-1-git-send-email-rkrcmar@redhat.com> <1438792381-19453-2-git-send-email-rkrcmar@redhat.com> <55CBA523.3010007@de.ibm.com> <20150813091110.GA26977@potion.brq.redhat.com> <55CC6370.3080606@redhat.com> In-Reply-To: <55CC6370.3080606@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15081310-0029-0000-0000-000005DD3446 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 925 Lines: 31 Am 13.08.2015 um 11:29 schrieb Paolo Bonzini: > > > On 13/08/2015 11:11, Radim Krčmář wrote: >>>> for the new interface. maybe we can rename kvm_check_request in a separate patch somewhen. >> I wonder why haven't we copied the naming convention from bit operations >> (or if programming would be better if German was its language), >> >> kvm_test_request >> kvm_set_request >> kvm_clear_request >> kvm_test_and_clear_request >> >> The only disadvantage is that >> kvm_test_and_clear_request >> is longer than >> kvm_check_request >> 123456789 >> by whooping 9 characters. >> >> I could live with that. > > Yes, that would be much better. +1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/