Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752159AbbHMKfX (ORCPT ); Thu, 13 Aug 2015 06:35:23 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:34786 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751006AbbHMKfV (ORCPT ); Thu, 13 Aug 2015 06:35:21 -0400 Date: Thu, 13 Aug 2015 16:05:16 +0530 From: Viresh Kumar To: Jonas Rabenstein Cc: "Rafael J. Wysocki\"" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Remove unselectable rule for arm-exynos-cpufreq.o Message-ID: <20150813103516.GS20238@linux> References: <1439461941-13953-1-git-send-email-jonas.rabenstein@studium.uni-erlangen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439461941-13953-1-git-send-email-jonas.rabenstein@studium.uni-erlangen.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1969 Lines: 45 On 13-08-15, 12:32, Jonas Rabenstein wrote: > With commit 2907ed4377d9 ("cpufreq: exynos: remove Exynos4x12 specific > cpufreq driver support"), the last specific Exynos-cpufreq driver > depending on ARM_EXYNOS_CPUFREQ was removed. As there is no > Exynos-specific cpufreq driver depending on the code in > drivers/cpufreq/exynos-cpufreq.c (selected by ARM_EXYNOS_CPUFREQ), > this file was deleted and ARM_EXYNOS_CPUFREQ removed from Kconfig. > After all, the rule in drivers/cpufreq/Makefile, to combine all > specific cpufreq drivers depending on the generic code for Exynos into > one objectfile is obsolete and can be removed. > > Remove unselectable rule for arm-exynos-cpufreq.o from > drivers/cpufreq/Makefile, which - if selectable - would generate an > always empty objectfile. > > Signed-off-by: Jonas Rabenstein > --- > I found this inconsistency using the undertaker and > undertaker-checkpatch tools (https://undertaker.cs.fau.de/). > > drivers/cpufreq/Makefile | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile > index bbc4a9f..958be2b 100644 > --- a/drivers/cpufreq/Makefile > +++ b/drivers/cpufreq/Makefile > @@ -52,7 +52,6 @@ obj-$(CONFIG_ARM_DT_BL_CPUFREQ) += arm_big_little_dt.o > > obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o > obj-$(CONFIG_UX500_SOC_DB8500) += dbx500-cpufreq.o > -obj-$(CONFIG_ARM_EXYNOS_CPUFREQ) += arm-exynos-cpufreq.o > obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o > obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o > obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ) += hisi-acpu-cpufreq.o Acked-by: Viresh Kumar -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/