Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752228AbbHMMr4 (ORCPT ); Thu, 13 Aug 2015 08:47:56 -0400 Received: from mail-oi0-f42.google.com ([209.85.218.42]:34297 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752139AbbHMMrz (ORCPT ); Thu, 13 Aug 2015 08:47:55 -0400 MIME-Version: 1.0 In-Reply-To: <1438795388-22743-2-git-send-email-edubezval@gmail.com> References: <1438795388-22743-1-git-send-email-edubezval@gmail.com> <1438795388-22743-2-git-send-email-edubezval@gmail.com> Date: Thu, 13 Aug 2015 14:47:54 +0200 Message-ID: Subject: Re: [PATCH 1/2] gpio/mxc: mask gpio interrupts in suspend From: Linus Walleij To: Eduardo Valentin Cc: Alexandre Courbot , ubrindis56@gmail.com, Fabio Estevam , Fabio Estevam , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1492 Lines: 34 On Wed, Aug 5, 2015 at 7:23 PM, Eduardo Valentin wrote: > From: Ulises Brindis > > Currently in the FSL platform all GPIO interrupts in a bank are muxed > into two GPIO lines to the GPC interrupt controller. In each GPIO bank > GPIOs 0-15 are OR'ed into one GPC interrupt controller interrupt and 16-31 > are OR'ed into another. With the current code, if any of the 0-15 or > 16-31 interrupts are marked as wakeup capable, all interrupts belonging > to that sub-bank (either 0-15 or 16-31) will wake up the device. This is > because interrupts are only being masked at the interrupt controller > and not at the GPIO controller. > > This patch allows masking of GPIO interrupts at the GPIO controller during > suspend if they have not been labeled wakeup capable. This patch uses > preexisting IRQCHIP_MASK_ON_SUSPEND flag while initializing the GPIO > interrupts to get the desired behavior. > > Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: linux-gpio@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Eduardo Valentin > Signed-off-by: Ulises Brindis Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/