Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752744AbbHMNp7 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 13 Aug 2015 09:45:59 -0400
Received: from hqemgate16.nvidia.com ([216.228.121.65]:17078 "EHLO
	hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752180AbbHMNp5 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 13 Aug 2015 09:45:57 -0400
X-PGP-Universal: processed;
	by hqnvupgp07.nvidia.com on Thu, 13 Aug 2015 06:43:01 -0700
Date: Thu, 13 Aug 2015 15:45:40 +0200
From: Sylvain Jeaugey <sjeaugey@nvidia.com>
X-X-Sender: nvidia@lenovo
To: =?ISO-8859-15?Q?J=E9r=F4me_Glisse?= <jglisse@redhat.com>
CC: <akpm@linux-foundation.org>, <linux-kernel@vger.kernel.org>,
        <linux-mm@kvack.org>, Linus Torvalds <torvalds@linux-foundation.org>,
        <joro@8bytes.org>, Mel Gorman <mgorman@suse.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Johannes Weiner <jweiner@redhat.com>,
        Larry Woodman <lwoodman@redhat.com>, Rik van Riel <riel@redhat.com>,
        Dave Airlie <airlied@redhat.com>, Brendan Conoboy <blc@redhat.com>,
        Joe Donohue <jdonohue@redhat.com>,
        Christophe Harle <charle@nvidia.com>, Duncan Poole <dpoole@nvidia.com>,
        Sherry Cheung <SCheung@nvidia.com>, Subhash Gutti <sgutti@nvidia.com>,
        John Hubbard <jhubbard@nvidia.com>,
        Mark Hairgrove <mhairgrove@nvidia.com>,
        Lucien Dunning <ldunning@nvidia.com>,
        "Cameron Buschardt" <cabuschardt@nvidia.com>,
        Arvind Gopalakrishnan <arvindg@nvidia.com>,
        Haggai Eran <haggaie@mellanox.com>,
        Shachar Raindel <raindel@mellanox.com>,
        Liran Liss <liranl@mellanox.com>,
        Roland Dreier <roland@purestorage.com>,
        Ben Sander <ben.sander@amd.com>, Greg Stoner <Greg.Stoner@amd.com>,
        John Bridgman <John.Bridgman@amd.com>,
        Michael Mantor <Michael.Mantor@amd.com>,
        Paul Blinzer <Paul.Blinzer@amd.com>,
        Leonid Shamis <Leonid.Shamis@amd.com>,
        Laurent Morichetti <Laurent.Morichetti@amd.com>,
        Alexander Deucher <Alexander.Deucher@amd.com>,
        Linda Wang <lwang@redhat.com>, Kevin E Martin <kem@redhat.com>,
        Jeff Law <law@redhat.com>, Or Gerlitz <ogerlitz@mellanox.com>,
        Sagi Grimberg <sagig@mellanox.com>
Subject: Re: [PATCH 15/15] hmm/dummy: dummy driver for testing and showcasing
 the HMM API
In-Reply-To: <1437159145-6548-16-git-send-email-jglisse@redhat.com>
Message-ID: <alpine.DEB.2.10.1508131016070.9016@lenovo>
References: <1437159145-6548-1-git-send-email-jglisse@redhat.com> <1437159145-6548-16-git-send-email-jglisse@redhat.com>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
X-NVConfidentiality: public
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-583387059-1439453849=:9016"
Content-ID: <alpine.DEB.2.10.1508131018071.9016@lenovo>
X-Originating-IP: [10.26.11.38]
X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL102.nvidia.com
 (10.26.138.15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1166
Lines: 31

--8323329-583387059-1439453849=:9016
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.10.1508131018072.9016@lenovo>

Hi Jerome,

I get a compilation error when building the hmm_dummy module (undefined 
function hmm_pte_test_select).

On Fri, 17 Jul 2015, J?r?me Glisse wrote:
> +static int dummy_mirror_pt_populate(struct hmm_mirror *mirror,
> +                                 struct hmm_event *event)
> [ snip ]
> +             if (!mpte || !hmm_pte_test_valid_pfn(mpte) ||
> +                 !hmm_pte_test_select(mpte)) {
>From what I understand, the select flag no longer exists in HMM PTE, 
hence hmm_pte_test_select is missing.
Removing this sanity check, the module compiles and loads correctly.

Aside from that problem, is there a userspace test available which 
interfaces with the dummy module ?

Thanks,
Sylvain
--8323329-583387059-1439453849=:9016--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/