Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753379AbbHMPnq (ORCPT ); Thu, 13 Aug 2015 11:43:46 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:33042 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752390AbbHMPno (ORCPT ); Thu, 13 Aug 2015 11:43:44 -0400 MIME-Version: 1.0 In-Reply-To: References: <55CA90B4.2010205@list.ru> From: Andy Lutomirski Date: Thu, 13 Aug 2015 08:43:24 -0700 Message-ID: Subject: Re: [regression] x86/signal/64: Fix SS handling for signals delivered to 64-bit programs breaks dosemu To: Linus Torvalds Cc: Stas Sergeev , Linux kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1511 Lines: 38 On Thu, Aug 13, 2015 at 8:37 AM, Linus Torvalds wrote: > On Tue, Aug 11, 2015 at 5:17 PM, Stas Sergeev wrote: >> >> I realize this patch may be good to have in general, but >> breaking userspace without a single warning is a bit >> discouraging. Seems like the old "we don't break userspace" >> rule have gone. > > That rule hasn't gone anywhere. > > Does a plain revert just fix everything? Because if so, that's the > right thing to do, and we can just re-visit this later. > > I don't understand why Andy and Ingo are even discussing this. What > the f*ck, guys? > I'm trying to fix it without reverting. If that doesn't work, then we revert. Yesterday, I thought I had a reasonably clean fix, but it turned out that it only solved half of the problem. If we revert, I think I need to check what will break due to the revert. I need to check at least Wine, and we'll have to do something about all the selftests that will start failing. I also need to check CRIU, and IIRC CRIU has started using the new sigcontext SS in new versions. And, damnit, those selftests are *useful*. They've smoked out all kinds of problems. That's part of the reason I'd prefer not to revert if there's a better option. --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/