Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753887AbbHMTgX (ORCPT ); Thu, 13 Aug 2015 15:36:23 -0400 Received: from lists.s-osg.org ([54.187.51.154]:57655 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752615AbbHMTgV (ORCPT ); Thu, 13 Aug 2015 15:36:21 -0400 Message-ID: <55CCF1B3.40900@osg.samsung.com> Date: Thu, 13 Aug 2015 13:36:19 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Naresh Kamboju , Tyler Baker CC: alexey.kodanev@oracle.com, "linux-kernel@vger.kernel.org" , lsk-team@linaro.org, Kevin Hilman , Milosz Wasilewski , Shuah Khan Subject: Re: [PATCH] selftests/zram: Adding zram tests References: <1436270600-15395-1-git-send-email-naresh.kamboju@linaro.org> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1735 Lines: 51 On 08/13/2015 01:08 PM, Naresh Kamboju wrote: > Hi Tyler, > > On 23 July 2015 at 05:30, Tyler Baker wrote: >> Hi Naresh, >> >> On 7 July 2015 at 05:03, wrote: >>> From: Naresh Kamboju >>> >>> zram_lib.sh: create library with initialization/cleanup functions >>> zram01.sh: creates general purpose ram disks with different filesystems >>> zram02.sh: creates block device for swap >>> README: ZRAM introduction and Kconfig required. >>> Makefile: To run zram tests >> >> (./zram01.sh && echo "selftests: zram01.sh [PASS]") || echo >> "selftests: zram01.sh [FAIL]" >> (./zram02.sh && echo "selftests: zram02.sh [PASS]") || echo >> "selftests: zram02.sh [FAIL]" >> (./zram_lib.sh && echo "selftests: zram_lib.sh [PASS]") || echo >> "selftests: zram_lib.sh [FAIL]" >> >> Above is the output from the run_kselftests.sh. Do we want to run >> zram_lib.sh as a test case as it just a library? > > zram_lib.sh is not a test as it just a library. > run_kselftest.sh should not pick this file as test case. Any idea howto ? > TEST_PROGS := zram01.sh zram02.sh zram_lib.sh The above tells run_kselftest.sh to run these. You will have to add zram_lib.h to TEST_FILES instead. Please take a look at other tests that do this. e.g: net/Makefile thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/