Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754162AbbHMU0E (ORCPT ); Thu, 13 Aug 2015 16:26:04 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53779 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754008AbbHMU0C (ORCPT ); Thu, 13 Aug 2015 16:26:02 -0400 Date: Thu, 13 Aug 2015 13:26:01 -0700 From: Andrew Morton To: Linus Torvalds Cc: Joonsoo Kim , Al Viro , Linux Kernel Mailing List Subject: Re: get_vmalloc_info() and /proc/meminfo insanely expensive Message-Id: <20150813132601.b749ff5caeb5647ec93c5274@linux-foundation.org> In-Reply-To: References: <20150812210027.88dfcf90.akpm@linux-foundation.org> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 799 Lines: 18 On Wed, 12 Aug 2015 22:52:44 -0700 Linus Torvalds wrote: > Looking at that mm/vmalloc.c file, the locking is pretty odd. It looks > pretty strange in setup_vmalloc_vm(), for example. If that newly > allocated "va" that we haven't even exposed to anybody yet has its > address or size changed, we're screwed in so many ways. > > I get the feeling this file should be rewritten. But that's not going > to happen. Nick Piggin started doing a rewrite in 2008 but it was never completed (https://lwn.net/Articles/285341/). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/