Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932080AbbHMU6F (ORCPT ); Thu, 13 Aug 2015 16:58:05 -0400 Received: from mail-la0-f68.google.com ([209.85.215.68]:33016 "EHLO mail-la0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752884AbbHMU6D (ORCPT ); Thu, 13 Aug 2015 16:58:03 -0400 MIME-Version: 1.0 In-Reply-To: <1437469005-3162-1-git-send-email-yao.yuan@freescale.com> References: <1437469005-3162-1-git-send-email-yao.yuan@freescale.com> Date: Thu, 13 Aug 2015 15:58:01 -0500 X-Google-Sender-Auth: 0Gmr3HfGug_ag93Q2MyPpOEpTcc Message-ID: Subject: Re: [PATCH v2] dmaengine: fsl-edma: add PM suspend/resume support From: Li Yang To: Yuan Yao Cc: Vinod Koul , stefan@agner.ch, Arnd Bergmann , Dan Williams , dmaengine@vger.kernel.org, lkml , "linux-arm-kernel@lists.infradead.org" , "linux-pm@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 774 Lines: 21 On Tue, Jul 21, 2015 at 3:56 AM, Yuan Yao wrote: > This add power management suspend/resume support for the fsl-edma > driver. > > eDMA acted as a basic function used by others. What it needs to do is > the two steps below to support power management. > > In fsl_edma_suspend_late: > Check whether the DMA chan is idle and if it is not idle, stop PM > operation. You should try to quiesce the device on suspend instead of depending on itself to be happen in idle and failing if it is not. Regards, Leo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/