Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 19 Feb 2003 09:16:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 19 Feb 2003 09:16:17 -0500 Received: from pushme.nist.gov ([129.6.16.92]:34755 "EHLO postmark.nist.gov") by vger.kernel.org with ESMTP id ; Wed, 19 Feb 2003 09:16:16 -0500 To: linux-kernel@vger.kernel.org Subject: Re: [PATCH]: M5451 (OSS trident.c) did not come out of reset References: <20030218151138.GU2492@actcom.co.il> From: Ian Soboroff Date: Wed, 19 Feb 2003 09:25:54 -0500 In-Reply-To: <20030218151138.GU2492@actcom.co.il> (Muli Ben-Yehuda's message of "Tue, 18 Feb 2003 17:11:38 +0200") Message-ID: <9cfd6lowdn1.fsf@rogue.ncsl.nist.gov> User-Agent: Gnus/5.090007 (Oort Gnus v0.07) Emacs/21.2 (i686-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 900 Lines: 17 Muli Ben-Yehuda writes: > Last time I booted 2.5, I noticed that my sound card no longer > works. The card is: > > 00:06.0 Multimedia audio controller: Acer Laboratories Inc. [ALi] > M5451 PCI AC-Link Controller Audio Device (rev 01) > > And the computer is a thinkpad R30. It turns out that this patch, from > Alan Cox on 01/11/2002, broke it for me, by failing ali_reset_5451 if > the card doesn't come out of reset: A similar change came in a 2.4.21pre-ac that broke sound on my Fujitsu P-2110. I patched it to return success even if it never appeared to come out of reset, and sound worked again. So that's another example. Ian - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/