Content-Type: text/plain;
	charset=gb2312
Mime-Version: 1.0 (1.0)
Subject: Re: [RFC PATCH v6 0/2] Make eBPF programs output data to perf
From: pi3orama <pi3orama@163.com>
In-Reply-To: <55CD0BCF.2030400@plumgrid.com>
Date: Fri, 14 Aug 2015 05:35:58 +0800
Cc: He Kuang <hekuang@huawei.com>, "rostedt@goodmis.org" <rostedt@goodmis.org>,
        "masami.hiramatsu.pt@hitachi.com" <masami.hiramatsu.pt@hitachi.com>,
        "acme@kernel.org" <acme@kernel.org>,
        "a.p.zijlstra@chello.nl" <a.p.zijlstra@chello.nl>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "namhyung@kernel.org" <namhyung@kernel.org>,
        "jolsa@kernel.org" <jolsa@kernel.org>,
        "wangnan0@huawei.com" <wangnan0@huawei.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Transfer-Encoding: 8BIT
Message-Id: <3DE5423D-3E4E-4395-846D-7D5EAD1BB911@163.com>
References: <1437448130-134621-1-git-send-email-hekuang@huawei.com> <55CD0BCF.2030400@plumgrid.com>
To: Alexei Starovoitov <ast@plumgrid.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1459
Lines: 37


?????ҵ? iPhone

> ?? 2015??8??14?գ?????5:27??Alexei Starovoitov <ast@plumgrid.com> д????
> 
>> On 7/20/15 8:08 PM, He Kuang wrote:
>> Hi,
>> 
>> Previous patch v5 url:
>> http://thread.gmane.org/gmane.linux.kernel/1995274
>> 
>> The bugfix of dynamic array length in trace event goes to
>> kernel/git/rostedt/linux-trace.git ftrace/urgent and confirms that the
>> return value of __get_dynamic_array_len() is the total allocated
>> length of the dynamic array. For we print the bpf output data in byte
>> array from patch v5, that problem does not affect our patch any more,
>> but some comments in patch 1/2 is updated.
>> 
>> Patch 2/2 is acked by Alexei.
> 
> what is the status of it? If I remember correctly patch 1 was fixed
> differently in Steven's tree. Patch 2 probably needs refreshing?
> 

I was thinking about whether to add a "type" field there, so we will have an explicit
mov const instruction before the call instruction, which can act as a mark. Also, if
we generate the type code automatically, a type field in this API can make things
easier since we don't need wrap the user structure in BPF stack. However, the
LLVM side is not ready yet, so we haven't post the new version.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/