Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754577AbbHMW4t (ORCPT ); Thu, 13 Aug 2015 18:56:49 -0400 Received: from mail-ig0-f178.google.com ([209.85.213.178]:38168 "EHLO mail-ig0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754556AbbHMW4q (ORCPT ); Thu, 13 Aug 2015 18:56:46 -0400 MIME-Version: 1.0 In-Reply-To: References: <55CCB510.3060807@redhat.com> <55CD0DAC.9080809@redhat.com> Date: Thu, 13 Aug 2015 15:56:45 -0700 X-Google-Sender-Auth: 8-OmQW7pWBjhLdp-D8aKo_HZGIY Message-ID: Subject: Re: [Regression v4.2 ?] 32-bit seccomp-BPF returned errno values wrong in VM? From: Kees Cook To: Linus Torvalds Cc: Andy Lutomirski , Denys Vlasenko , David Drysdale , "linux-kernel@vger.kernel.org" , Will Drewry , Ingo Molnar , Alok Kataria , Borislav Petkov , Alexei Starovoitov , Frederic Weisbecker , "H. Peter Anvin" , Oleg Nesterov , Steven Rostedt , X86 ML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 907 Lines: 29 On Thu, Aug 13, 2015 at 3:54 PM, Linus Torvalds wrote: > On Thu, Aug 13, 2015 at 3:49 PM, Linus Torvalds > wrote: >> >> Does the attached patch make sense and work? > > Btw, I'm not all that happy with it anyway. > > I still think Denys' patch also potentially changed what audit and > strace see for %rax in the pt_regs to -ENOSYS, which I'm not convinced > is a good change. > > But maybe that three-liner patch fixes the immediate problem that > David sees. David? Your patch fixes it for me. The seccomp compat selftests pass again with audit enabled. -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/