Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754200AbbHMXO5 (ORCPT ); Thu, 13 Aug 2015 19:14:57 -0400 Received: from mail-io0-f182.google.com ([209.85.223.182]:33455 "EHLO mail-io0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753089AbbHMXOz (ORCPT ); Thu, 13 Aug 2015 19:14:55 -0400 MIME-Version: 1.0 In-Reply-To: References: <55CCB510.3060807@redhat.com> <55CD0DAC.9080809@redhat.com> Date: Thu, 13 Aug 2015 16:14:54 -0700 X-Google-Sender-Auth: p7_cU4oCVL0UwdKpO1ni801_6VY Message-ID: Subject: Re: [Regression v4.2 ?] 32-bit seccomp-BPF returned errno values wrong in VM? From: Kees Cook To: Andy Lutomirski Cc: Linus Torvalds , Denys Vlasenko , David Drysdale , "linux-kernel@vger.kernel.org" , Will Drewry , Ingo Molnar , Alok Kataria , Borislav Petkov , Alexei Starovoitov , Frederic Weisbecker , "H. Peter Anvin" , Oleg Nesterov , Steven Rostedt , X86 ML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1558 Lines: 40 On Thu, Aug 13, 2015 at 3:59 PM, Andy Lutomirski wrote: > On Thu, Aug 13, 2015 at 3:56 PM, Kees Cook wrote: >> On Thu, Aug 13, 2015 at 3:54 PM, Linus Torvalds >> wrote: >>> On Thu, Aug 13, 2015 at 3:49 PM, Linus Torvalds >>> wrote: >>>> >>>> Does the attached patch make sense and work? >>> >>> Btw, I'm not all that happy with it anyway. >>> >>> I still think Denys' patch also potentially changed what audit and >>> strace see for %rax in the pt_regs to -ENOSYS, which I'm not convinced >>> is a good change. >>> >>> But maybe that three-liner patch fixes the immediate problem that >>> David sees. David? >> >> Your patch fixes it for me. The seccomp compat selftests pass again >> with audit enabled. > > Kees, would it be straightforward to rig up the seccomp tests to > automatically test compat? The x86 selftests automatically test both > native and compat, and that might be usable as a model. I did that > because it's extremely easy to regress one and not the other. Yeah, I'll figure out how to get this working sanely. There are some ugly behaviors on arm64 doing compat that seccomp found too, so I'll need those targets for more than just x86. -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/