Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754386AbbHMXST (ORCPT ); Thu, 13 Aug 2015 19:18:19 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34889 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753103AbbHMXSQ (ORCPT ); Thu, 13 Aug 2015 19:18:16 -0400 Message-ID: <55CD25B6.6050901@codeaurora.org> Date: Thu, 13 Aug 2015 16:18:14 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Mathieu Olivari CC: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, dwmw2@infradead.org, computersforpeace@gmail.com, agross@codeaurora.org, bjorn.andersson@sonymobile.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH 1/3] ARM: qcom: add SFPB nodes to IPQ806x dts References: <1439501620-24073-1-git-send-email-mathieu@codeaurora.org> <1439501620-24073-2-git-send-email-mathieu@codeaurora.org> In-Reply-To: <1439501620-24073-2-git-send-email-mathieu@codeaurora.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1469 Lines: 50 On 08/13/2015 02:33 PM, Mathieu Olivari wrote: > Add one new node to the ipq806x.dtsi file to declare & register the > hardware spinlock devices. This mechanism is required to be used by > other drivers such as SMEM. > > Signed-off-by: Mathieu Olivari > --- > arch/arm/boot/dts/qcom-ipq8064.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi > index 9f727d8..ea7b959 100644 > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi > @@ -67,6 +67,18 @@ > clock-frequency = <32768>; > #clock-cells = <0>; > }; > + > + sfpb_mutex_block: syscon@01200600 { I think you can drop the leading 0 here. Also this should be moved into the soc node. > + compatible = "syscon"; > + reg = <0x01200600 0x100>; > + }; > + > + sfpb_mutex: sfpb-mutex { > + compatible = "qcom,sfpb-mutex"; > + syscon = <&sfpb_mutex_block 4 4>; > + > + #hwlock-cells = <1>; > + }; And this node should be moved to the root /. > }; > > soc: soc { -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/