Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752400AbbHNFdm (ORCPT ); Fri, 14 Aug 2015 01:33:42 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:33759 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750728AbbHNFdj (ORCPT ); Fri, 14 Aug 2015 01:33:39 -0400 MIME-Version: 1.0 Reply-To: mtk.manpages@gmail.com In-Reply-To: References: <1439458366-8223-1-git-send-email-drysdale@google.com> <1439458366-8223-4-git-send-email-drysdale@google.com> From: "Michael Kerrisk (man-pages)" Date: Fri, 14 Aug 2015 07:33:17 +0200 Message-ID: Subject: Re: [PATCHv4 man-pages 3/3] open.2: describe O_BENEATH flag To: Andy Lutomirski Cc: David Drysdale , "linux-kernel@vger.kernel.org" , Alexander Viro , Kees Cook , "Eric W. Biederman" , Greg Kroah-Hartman , Meredydd Luff , Will Drewry , Jorge Lucangeli Obes , Ricky Zhou , Lee Campbell , Julien Tinnes , Mike Depinet , James Morris , Paolo Bonzini , Paul Moore , Christoph Hellwig , Dave Chinner , Linux API , linux-arch , LSM List , Linux FS Devel , fstests Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1466 Lines: 36 On 13 August 2015 at 19:38, Andy Lutomirski wrote: > On Thu, Aug 13, 2015 at 2:32 AM, David Drysdale wrote: >> Signed-off-by: David Drysdale > > What's the behavior wrt fcntl(F_GETFL, etc)? I would presume that O_BENEATH is one of the so-called "file creation flags". See this paragraph of the DESCRIPTION: In addition, zero or more file creation flags and file status flags can be bitwise-or'd in flags. The file creation flags are O_CLOEXEC, O_CREAT, O_DIRECTORY, O_EXCL, O_NOCTTY, O_NOFOLLOW, O_TMPFILE, O_TRUNC, and O_TTY_INIT. The file status flags are all of the remaining flags listed below. The distinction between these two groups of flags is that the file status flags can be retrieved and (in some cases) modified; see fcntl(2) for details. David, presuming this is correct (I can't see how O_BENEATH could be a "file *status* flag"), your patch should also add O_BENEATH to the list in that paragraph. Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/