Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753968AbbHNILO (ORCPT ); Fri, 14 Aug 2015 04:11:14 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:36461 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752403AbbHNILC (ORCPT ); Fri, 14 Aug 2015 04:11:02 -0400 Date: Fri, 14 Aug 2015 11:10:58 +0300 From: Cyrill Gorcunov To: Andy Lutomirski Cc: Linus Torvalds , Stas Sergeev , Linux kernel Subject: Re: [regression] x86/signal/64: Fix SS handling for signals delivered to 64-bit programs breaks dosemu Message-ID: <20150814081058.GB2129@uranus> References: <55CA90B4.2010205@list.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1595 Lines: 37 On Thu, Aug 13, 2015 at 08:43:24AM -0700, Andy Lutomirski wrote: ... > > > > That rule hasn't gone anywhere. > > > > Does a plain revert just fix everything? Because if so, that's the > > right thing to do, and we can just re-visit this later. > > > > I don't understand why Andy and Ingo are even discussing this. What > > the f*ck, guys? > > > > I'm trying to fix it without reverting. If that doesn't work, then we > revert. Yesterday, I thought I had a reasonably clean fix, but it > turned out that it only solved half of the problem. > > If we revert, I think I need to check what will break due to the > revert. I need to check at least Wine, and we'll have to do something > about all the selftests that will start failing. I also need to check > CRIU, and IIRC CRIU has started using the new sigcontext SS in new > versions. Yes, we've tuned up our sigcontext structure and put ss into the place where previously __pad0 were. After the revert the kernel simply ignores this field again. But we never did any "weird" gaming over segment registers for testing purposes, neither we note any application (in containers) which does some weird things like dosemu. > > And, damnit, those selftests are *useful*. They've smoked out all > kinds of problems. That's part of the reason I'd prefer not to revert > if there's a better option. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/