Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754828AbbHNJsn (ORCPT ); Fri, 14 Aug 2015 05:48:43 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:57433 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754158AbbHNJru (ORCPT ); Fri, 14 Aug 2015 05:47:50 -0400 Message-ID: <55CDB80E.2030403@ti.com> Date: Fri, 14 Aug 2015 12:42:38 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Peter Chen CC: , , , , , , , , , , Subject: Re: [PATCH v3 07/11] usb: otg: add OTG core References: <1436350777-28056-1-git-send-email-rogerq@ti.com> <1436350777-28056-8-git-send-email-rogerq@ti.com> <20150713021456.GE27710@shlinux2> <55A390FB.5080406@ti.com> In-Reply-To: <55A390FB.5080406@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3112 Lines: 94 Hi Peter, On 13/07/15 13:20, Roger Quadros wrote: > On 13/07/15 05:14, Peter Chen wrote: >> On Wed, Jul 08, 2015 at 01:19:33PM +0300, Roger Quadros wrote: >>> The OTG core instantiates the OTG Finite State Machine >>> per OTG controller and manages starting/stopping the >>> host and gadget controllers based on the bus state. >>> >>> It provides APIs for the following tasks >>> >>> - Registering an OTG capable controller >>> - Registering Host and Gadget controllers to OTG core >>> - Providing inputs to and kicking the OTG state machine >>> >>> Signed-off-by: Roger Quadros >>> --- >>> MAINTAINERS | 4 +- >>> drivers/usb/Kconfig | 2 +- >>> drivers/usb/Makefile | 1 + >>> drivers/usb/common/Makefile | 3 +- >>> drivers/usb/common/usb-otg.c | 768 +++++++++++++++++++++++++++++++++++++++++++ >>> drivers/usb/common/usb-otg.h | 71 ++++ >>> drivers/usb/core/Kconfig | 11 +- >>> include/linux/usb/otg.h | 91 ++++- >>> 8 files changed, 930 insertions(+), 21 deletions(-) >>> create mode 100644 drivers/usb/common/usb-otg.c >>> create mode 100644 drivers/usb/common/usb-otg.h >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index 8133cef..b21278e 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -10640,12 +10640,14 @@ S: Maintained >>> F: Documentation/usb/ohci.txt >>> F: drivers/usb/host/ohci* >>> >>> -USB OTG FSM (Finite State Machine) >>> +USB OTG/DRD core and FSM (Finite State Machine) >>> M: Peter Chen >>> +M: Roger Quadros >>> T: git git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git >>> L: linux-usb@vger.kernel.org >>> S: Maintained >>> F: drivers/usb/common/usb-otg-fsm.c >>> +F: drivers/usb/common/usb-otg.c >>> >>> USB OVER IP DRIVER >>> M: Valentina Manea >>> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig >>> index 8ed451d..5b625e2 100644 >>> --- a/drivers/usb/Kconfig >>> +++ b/drivers/usb/Kconfig >>> @@ -32,7 +32,7 @@ if USB_SUPPORT >>> config USB_COMMON >>> tristate >>> default y >>> - depends on USB || USB_GADGET >>> + depends on USB || USB_GADGET || USB_OTG >>> >> >> USB_OTG can depends on USB || UB_GADGET? > > I didn't understand. The above is for USB_COMMON. > >> >>> config USB_ARCH_HAS_HCD >>> def_bool y >>> diff --git a/drivers/usb/Makefile b/drivers/usb/Makefile >>> index d8926c6..769d13b 100644 >>> --- a/drivers/usb/Makefile >>> +++ b/drivers/usb/Makefile >>> @@ -60,5 +60,6 @@ obj-$(CONFIG_USB_RENESAS_USBHS) += renesas_usbhs/ >>> obj-$(CONFIG_USB_GADGET) += gadget/ >>> >>> obj-$(CONFIG_USB_COMMON) += common/ >>> +obj-$(CONFIG_USB_OTG) += common/ >>> >> >> The comment like above. > > What should it look like? > Can you please clarify what you meant at the above two comments? Thanks. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/